The source code does not support setting boolean to allowedClasses. It only supports this for individual tags in allowedClasses. E.g. { p: false } will allow all classes for the p tag.
* update types to support username field for Redis 6 auth
* update version of library
* switch order around so more specific is first
* comment out password option to get human attention
* add tslint:disable for unified-signatures
microsoft/TypeScript#39081, which ships in Typescript 4.0, stops using
binding patterns as contextual types for return type inference.
react-router's `useParams` relied on this to fill in an object with
`any`s in case a binding pattern was used but no type argument was
provided. This no longer works.
This fix just adds a type argument to the tests.
For two other, more complete fixes, see
https://github.com/microsoft/TypeScript/pull/39081#issuecomment-644393729
Briefly, the options are (1) go back to returning `any`-filled object
types or (2) tries to default to `string`.
The second fix is probably the right one, but it may hurt
compilation/IDE performance, so I'll leave it to the package owners to
decide whether to make that change.
* Type declaration for agent() return type
## The case
In my project, it is essential to always clarify the variable type. In my case, writing a test suite would require to declare variables (so that they could be accessed in other scopes) and then later initialize them in a different block
## An example
```ts
describe("Health module", () => {
// In this case I must declare variables here
let app: NestApplication;
let agent: any; // I could just copy and paste that huge return type, but it will break the code style. Using `any` is also a bad practice I guess
beforeAll(() => {
/* some code */
// initialization goes here
agent = supertest.agent(app.getHttpServer());
});
/* some code */
});
```
## Proposal
Declaring the return type of the agent function would be great, however, considering that I'm new to this library there may be a type declared already.
P.S. `SuperTestAgent` is just the first thing that I could come up with, it should be named more properly
* running lint
* Updated test cases to cover other methods
* Added TypeScript 3.0 comment
* Fixed linting issues
* Added server manager method and MediaServer interface
If you're doing anything interesting within `Server.shouldHandle` it's probably going to involve database queries, crypto hashing, or other features that are generally provided asynchronously. Changing the signature to allow `boolean | Promise<boolean>` fixes the compiler error that occurs if you attempt to assign an async function to `shouldHandle` (async functions must return promises, but then the function signature doesn't match).
* prosemirror-state and prosemirror-view: Specify 'this' binding
Various functions in prosemirror-state and prosemirror-view have specific,
documented bindings for 'this':
* All functions in EditorProps and StateField have their 'this' binding set to
type 'Plugin' (the plugin instance)
* DirectEditorProps.dispatchTransaction() has its 'this' binding set to type
'EditorView' (the view instance)
* Add my name to headers
* Prosemirror: Changes as per code review
* Feature.ReactSvgRadarChart. Add typings for package react-svg-radar-chart
* Feature.ReactSvgRadarChart.Adding ReadonlyArray instead of normal one
* Feature.ReactSvgRadarChart. Added more default values to show and set some properties optional.
* Adding newline where it should exist
* Remove trailing whitespace.
Adding minimum because linting throws errors other way
* Leaving the minimum ts version only
Co-authored-by: Lukas Tutkus <lukas.tutkus@macaw.nl>
* update(gh-pages): v3 bump
This version (as per release notes) does not change API. So this just
aligns with source code package version:
https://github.com/tschaub/gh-pages/releases/tag/v3.0.0
Thanks!
* Add `defaults` export as per PR check
* feat(write-file-encoding): add support for encoding option
The api supports string as an option This string option is the encodign
of the data, defaulting to 'utf8'. As the Node types are referenced,
simply BufferEncoding is beign used instead of string or string aliases
to align with Node types.
For backward compatiblity options 'encoding' is defined as:
BufferEncoding | ''
https://github.com/npm/write-file-atomic#write-file-atomic
Thanks!
* Be specific about allowed encoding as per PR comment
/cc @amcasey
* Adding type extractors and updating existing tests to use them.
* Improving handling of mixed-iterability types by simplifying the Underscore and chain functions to a single overload.
* Updating TypeOfCollection to check against List and Dictionary separately instead of using Collection since using the latter behaves oddly with JQuery objects.
* Renaming a variable to something slightly more friendly.
* Renaming variables in tests.
* Add support for Promises in redux-api-middleware
fix
* Change promises result type def in redux-api-middleware
Reducing the duplication in the type definitions for the Promises return types in functions.
Change promises result type def in redux-api-middleware
* fix(dygraphs): Allow nullable `valueRange` array type
When setting a `valueRange` option on a dygraph chart, it is valid to provide a `null` value for the range, in which case the chart range will auto-detect the upper or lower bound.
Doc reference: http://dygraphs.com/options.html#valueRange
This change modifies the required option type to accept an array with `null` elements, as well as constrains the value to be a tuple array of length 2.
* fix(dygraphs): Add `null` type for `valueRange` type union
* f