mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 20:51:43 +00:00
In a recent incident it was bought up that hot fixing searcher had a risk since it speaks to the DB. I investigated and noticed it doesn't actually connect, but does have dbconn as an unused transitive dep. This commit refactors out the bit of logic used by searcher into a pure package. To do so I did a few renames, but functionally there is no change in logic other than the searcher binary shedding some heavy dependencies. Additionally I updated the go-dbconn-import check to ensure searcher isn't accidently using the database again. Test Plan: CI |
||
|---|---|---|
| .. | ||
| bodyclose | ||
| dbconn | ||
| depguard | ||
| exportloopref | ||
| forbidigo | ||
| gocheckcompilerdirectives | ||
| gocritic | ||
| ineffassign | ||
| logging | ||
| nolint | ||
| nolocalhost | ||
| staticcheck | ||
| tracinglibraries | ||
| unparam | ||
| unused | ||
| go.mod | ||
| go.sum | ||