sourcegraph/dev/linters
Keegan Carruthers-Smith 57a2330d98
searcher: remove unused dependency on dbconn pkg (#61463)
In a recent incident it was bought up that hot fixing searcher had a
risk since it speaks to the DB. I investigated and noticed it doesn't
actually connect, but does have dbconn as an unused transitive dep.

This commit refactors out the bit of logic used by searcher into a pure
package. To do so I did a few renames, but functionally there is no
change in logic other than the searcher binary shedding some heavy
dependencies.

Additionally I updated the go-dbconn-import check to ensure searcher
isn't accidently using the database again.

Test Plan: CI
2024-03-28 17:11:41 +02:00
..
bodyclose bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
dbconn searcher: remove unused dependency on dbconn pkg (#61463) 2024-03-28 17:11:41 +02:00
depguard depguard: only allow github.com/sourcegraph/sourcegraph/lib/pointers (#59278) 2024-01-02 14:58:58 +00:00
exportloopref bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
forbidigo bazel: add sgexit lint to nogo (#59092) 2023-12-19 14:46:33 +00:00
gocheckcompilerdirectives bzl: port go compiler directives linter from sg lint to nogo (#54485) 2023-06-30 14:31:15 +02:00
gocritic bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
ineffassign bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
logging bazel: first pass at moving moving logging linting into nogo (#58910) 2024-01-02 10:07:25 -08:00
nolint Linting: make new unused lint respect nolint (#55677) 2023-08-09 17:10:45 +00:00
nolocalhost bazel: add no-localhost-guard lint to nogo (#59144) 2023-12-21 16:30:33 +00:00
staticcheck bazel: migrate go:generate for staticcheck (#59215) 2024-01-02 13:02:50 +00:00
tracinglibraries bazel: add tracing libraries lint to nogo (#58929) 2023-12-18 13:50:57 +00:00
unparam bazel: add unparam nogo linter (#50730) 2023-04-18 10:03:35 +00:00
unused Linting: make new unused lint respect nolint (#55677) 2023-08-09 17:10:45 +00:00
go.mod bazel: add sgexit lint to nogo (#59092) 2023-12-19 14:46:33 +00:00
go.sum bazel: adapt go-dbconn-check.sh lint to nogo (#58971) 2023-12-19 09:56:58 +00:00