bazel: first pass at moving moving logging linting into nogo (#58910)

* First pass at moving moving logging linting into Bazel

* fixed negation operators

* Update dev/linters/logging/logging.go

Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>

* added more exceptions and refactored one or two impls

* added nogo lint pragmas to offending files

* ran configure

* reverted git-combine refactor

* ran configure

* reverted test as well

---------

Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>

BUILD.bazel

@@ -315,6 +315,7 @@ nogo(
             "//dev/linters/gocheckcompilerdirectives",
             "//dev/linters/gocritic",
             "//dev/linters/ineffassign",
+            "//dev/linters/logging",
             "//dev/linters/unparam",
             "//dev/linters/tracinglibraries",
             "//dev/linters/dbconn",

cmd/frontend/globals/globals.go

@@ -7,7 +7,7 @@ import (
 	"sync"
 	"sync/atomic"
 
-	"github.com/inconshreveable/log15" //nolint:go
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log //nolint:go
 
 	"github.com/sourcegraph/sourcegraph/internal/conf"
 	"github.com/sourcegraph/sourcegraph/schema"

cmd/frontend/graphqlbackend/external_service_collaborators.go

@@ -8,7 +8,7 @@ import (
 	"sync"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/database"
 	"github.com/sourcegraph/sourcegraph/internal/extsvc/github"

cmd/frontend/graphqlbackend/git_tree_entry.go

@@ -12,7 +12,7 @@ import (
 	"sync"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"go.opentelemetry.io/otel/attribute"
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/envvar"

cmd/frontend/graphqlbackend/graphqlbackend_test.go

@@ -6,7 +6,7 @@ import (
 	"flag"
 	"fmt"
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"net/http/httptest"
 	"net/url"
@@ -16,7 +16,7 @@ import (
 	"testing"
 
 	"github.com/grafana/regexp"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	sglog "github.com/sourcegraph/log"
 	"github.com/sourcegraph/log/logtest"
 	"github.com/stretchr/testify/assert"

cmd/frontend/graphqlbackend/repository_comparison.go

@@ -11,7 +11,7 @@ import (
 	"strings"
 	"sync"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/sourcegraph/conc/pool"
 	"github.com/sourcegraph/go-diff/diff"
 

cmd/frontend/graphqlbackend/search_results.go

@@ -9,7 +9,7 @@ import (
 	"sync"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promauto"
 	"go.opentelemetry.io/otel/attribute"

cmd/frontend/graphqlbackend/site_admin.go

@@ -6,7 +6,7 @@ import (
 	"time"
 
 	"github.com/graph-gophers/graphql-go"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/log"
 

cmd/frontend/graphqlbackend/site_alerts.go

@@ -9,7 +9,7 @@ import (
 
 	"github.com/Masterminds/semver"
 	"github.com/gomodule/redigo/redis"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/hooks"
 	"github.com/sourcegraph/sourcegraph/internal/actor"

cmd/frontend/graphqlbackend/site_reload.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/internal/processrestart"
 	"github.com/sourcegraph/sourcegraph/internal/actor"

cmd/frontend/graphqlbackend/survey_response.go

@@ -5,7 +5,7 @@ import (
 
 	"github.com/graph-gophers/graphql-go"
 	"github.com/graph-gophers/graphql-go/relay"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/hubspot/hubspotutil"
 	sgactor "github.com/sourcegraph/sourcegraph/internal/actor"

cmd/frontend/graphqlbackend/user_usage_stats.go

@@ -7,7 +7,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promauto"
 

cmd/frontend/hubspot/hubspotutil/hubspotutil.go

@@ -2,9 +2,9 @@ package hubspotutil
 
 import (
 	"context"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/envvar"
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/hubspot"

cmd/frontend/internal/app/debug.go

@@ -6,7 +6,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"net/http/httputil"
 	"net/url"

cmd/frontend/internal/app/debugproxies/scanner.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/watch"
 	"k8s.io/client-go/kubernetes"

cmd/frontend/internal/app/errorutil/handlers.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"net/http"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/internal/handlerutil"
 	"github.com/sourcegraph/sourcegraph/internal/conf"

cmd/frontend/internal/app/opensearch.go

@@ -5,7 +5,7 @@ import (
 	"html/template"
 	"net/http"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/globals"
 )

cmd/frontend/internal/app/otlpadapter/register.go

@@ -14,7 +14,7 @@ import (
 	"go.opentelemetry.io/otel/sdk/metric"
 
 	"go.uber.org/atomic"
-	"go.uber.org/zap"
+	"go.uber.org/zap" //nolint:logging // dependencies require direct usage of zap
 
 	"github.com/sourcegraph/sourcegraph/internal/otlpenv"
 	"github.com/sourcegraph/sourcegraph/lib/errors"

cmd/frontend/internal/app/ping.go

@@ -5,7 +5,7 @@ import (
 	"io"
 	"net/http"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/auth"
 	"github.com/sourcegraph/sourcegraph/internal/database"

cmd/frontend/internal/app/ui/landing.go

@@ -4,7 +4,7 @@ import (
 	"net/http"
 
 	"github.com/gorilla/mux"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promauto"
 

cmd/frontend/internal/app/usage_stats.go

@@ -3,7 +3,7 @@ package app
 import (
 	"net/http"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/auth"
 	"github.com/sourcegraph/sourcegraph/internal/database"

cmd/frontend/internal/auth/githuboauth/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

cmd/frontend/internal/auth/githuboauth/provider.go

@@ -8,7 +8,7 @@ import (
 	"github.com/dghubble/gologin/v2"
 	"github.com/dghubble/gologin/v2/github"
 	goauth2 "github.com/dghubble/gologin/v2/oauth2"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"golang.org/x/oauth2"
 
 	gh "github.com/sourcegraph/sourcegraph/internal/extsvc/github"

cmd/frontend/internal/auth/githuboauth/session.go

@@ -10,7 +10,7 @@ import (
 	"time"
 
 	"github.com/dghubble/gologin/v2/github"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"golang.org/x/oauth2"
 
 	"github.com/sourcegraph/log"

cmd/frontend/internal/auth/httpheader/middleware.go

@@ -5,7 +5,7 @@ import (
 	"net/http"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/auth"
 	"github.com/sourcegraph/sourcegraph/internal/actor"

cmd/frontend/internal/auth/httpheader/testproxy.go

@@ -11,7 +11,7 @@ package main
 
 import (
 	"flag"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"net/http/httputil"
 	"net/url"

cmd/frontend/internal/auth/oauth/middleware.go

@@ -10,7 +10,7 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"go.opentelemetry.io/otel/attribute"
 	"golang.org/x/oauth2"
 

cmd/frontend/internal/auth/oauth/provider.go

@@ -10,7 +10,7 @@ import (
 	"path"
 
 	goauth2 "github.com/dghubble/gologin/v2/oauth2"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"golang.org/x/oauth2"
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/external/session"

cmd/frontend/internal/auth/openidconnect/middleware.go

@@ -11,7 +11,7 @@ import (
 	"time"
 
 	"github.com/coreos/go-oidc"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/russellhaering/gosaml2/uuid"
 	"golang.org/x/oauth2"
 

cmd/frontend/internal/auth/saml/config.go

@@ -6,13 +6,13 @@ import (
 	"encoding/base64"
 	"encoding/json"
 	"fmt"
-	stdlog "log"
+	stdlog "log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"path"
 	"strconv"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/sourcegraph/log"
 
 	"github.com/sourcegraph/sourcegraph/internal/auth/providers"

cmd/frontend/internal/auth/saml/middleware.go

@@ -9,7 +9,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/auth"
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/external/session"

cmd/frontend/internal/batches/resolvers/main_test.go

@@ -12,7 +12,7 @@ import (
 	"time"
 
 	"github.com/graph-gophers/graphql-go"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/log"
 

cmd/frontend/internal/batches/webhooks/webhooks.go

@@ -9,7 +9,7 @@ import (
 
 	sglog "github.com/sourcegraph/log"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/api"
 	"github.com/sourcegraph/sourcegraph/internal/batches/state"

cmd/frontend/internal/bg/check_redis_cache_eviction_policy.go

@@ -5,7 +5,7 @@ import (
 	"strings"
 
 	"github.com/gomodule/redigo/redis"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/redispool"
 	"github.com/sourcegraph/sourcegraph/lib/errors"

cmd/frontend/internal/bg/delete_old_cache_data_in_redis.go

@@ -1,7 +1,7 @@
 package bg
 
 import (
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/rcache"
 	"github.com/sourcegraph/sourcegraph/internal/redispool"

cmd/frontend/internal/cli/loghandlers/loghandlers.go

@@ -6,7 +6,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // Legacy loghandlers for log15
 )
 
 // Trace returns a filter for the given traces that run longer than threshold

cmd/frontend/internal/cli/loghandlers/loghandlers_test.go

@@ -4,7 +4,7 @@ import (
 	"testing"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestNotNoisey(t *testing.T) {

cmd/frontend/internal/cli/middleware/goimportpath.go

@@ -2,7 +2,7 @@ package middleware
 
 import (
 	"html/template"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"path"
 	"strings"

cmd/frontend/internal/cli/middleware/trace.go

@@ -1,7 +1,7 @@
 package middleware
 
 import (
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"net/http/httputil"
 	"strconv"

cmd/frontend/internal/cli/serve_cmd.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"os"
 	"time"

cmd/frontend/internal/cli/sysreq.go

@@ -6,7 +6,7 @@ import (
 	"io"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/kr/text"
 
 	"github.com/sourcegraph/sourcegraph/internal/env"

cmd/frontend/internal/compute/resolvers/resolvers.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/sourcegraph/log"
 
 	"github.com/sourcegraph/go-langserver/pkg/lsp"

cmd/frontend/internal/handlerutil/handler.go

@@ -7,7 +7,7 @@ import (
 	"os"
 	"runtime"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/errcode"
 	"github.com/sourcegraph/sourcegraph/lib/errors"

cmd/frontend/internal/httpapi/db_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

cmd/frontend/internal/httpapi/httpapi.go

@@ -2,7 +2,7 @@ package httpapi
 
 import (
 	"context"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"os"
 	"reflect"

cmd/frontend/internal/licensing/enforcement/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

cmd/frontend/internal/licensing/enforcement/users.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/frontend/envvar"
 	"github.com/sourcegraph/sourcegraph/internal/actor"

cmd/frontend/webhooks/github_webhooks.go

@@ -7,7 +7,7 @@ import (
 	"strconv"
 
 	"github.com/google/go-github/v55/github"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/log"
 

cmd/frontend/webhooks/middleware.go

@@ -6,7 +6,7 @@ import (
 	"io"
 	"net/http"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/conf"
 	"github.com/sourcegraph/sourcegraph/internal/database"

cmd/gitserver/internal/cleanup_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"io"
 	"io/fs"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"os/exec"
 	"path"

cmd/repo-updater/internal/authz/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

cmd/repo-updater/internal/repoupdater/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

cmd/searcher/internal/search/zipcache.go

@@ -5,7 +5,7 @@ import (
 	"fmt"
 	"hash/fnv"
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"sort"
 	"sync"

cmd/server/internal/goreman/proc.go

@@ -1,7 +1,7 @@
 package goreman
 
 import (
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"os/signal"
 	"sync"

cmd/server/internal/goremancmd/main.go

@@ -3,7 +3,7 @@
 package main
 
 import (
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 
 	"github.com/sourcegraph/sourcegraph/cmd/server/internal/goreman"

cmd/server/shared/conf_parse.go

@@ -1,7 +1,7 @@
 package shared
 
 import (
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 )
 

cmd/server/shared/copy.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"fmt"
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"os/exec"
 	"path/filepath"

cmd/server/shared/shared.go

@@ -8,7 +8,7 @@ import (
 	"encoding/json"
 	"flag"
 	"fmt"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"os/exec"
 	"path/filepath"

cmd/symbols/internal/database/janitor/cache_evicter.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/diskcache"
 	"github.com/sourcegraph/sourcegraph/internal/goroutine"

cmd/symbols/internal/database/store/store.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"database/sql"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/cmd/symbols/parser"
 	"github.com/sourcegraph/sourcegraph/internal/database/basestore"

cmd/symbols/parser/parser.go

@@ -6,7 +6,7 @@ import (
 	"sync"
 	"sync/atomic"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/sourcegraph/go-ctags"
 	"go.opentelemetry.io/otel/attribute"
 

cmd/symbols/squirrel/http_handlers.go

@@ -9,7 +9,8 @@ import (
 	"os"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
+
 	symbolsTypes "github.com/sourcegraph/sourcegraph/cmd/symbols/types"
 	"github.com/sourcegraph/sourcegraph/internal/types"
 	"github.com/sourcegraph/sourcegraph/lib/errors"

cmd/worker/internal/executorqueue/aws_reporter.go

@@ -8,7 +8,7 @@ import (
 	"github.com/aws/aws-sdk-go-v2/credentials"
 	"github.com/aws/aws-sdk-go-v2/service/cloudwatch"
 	"github.com/aws/aws-sdk-go-v2/service/cloudwatch/types"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/env"
 )

cmd/worker/internal/executorqueue/gcp_reporter.go

@@ -6,7 +6,7 @@ import (
 
 	monitoring "cloud.google.com/go/monitoring/apiv3/v2"
 	"cloud.google.com/go/monitoring/apiv3/v2/monitoringpb"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"google.golang.org/api/option"
 	metricpb "google.golang.org/genproto/googleapis/api/metric"
 	"google.golang.org/genproto/googleapis/api/monitoredres"

cmd/worker/internal/executorqueue/queue_allocation.go

@@ -3,7 +3,7 @@ package executorqueue
 import (
 	"slices"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	executortypes "github.com/sourcegraph/sourcegraph/internal/executor/types"
 	"github.com/sourcegraph/sourcegraph/lib/errors"

cmd/worker/internal/webhooks/handler.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/conf"
 	"github.com/sourcegraph/sourcegraph/internal/database"

dev/linters/logging/BUILD.bazel

@@ -0,0 +1,13 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "logging",
+    srcs = ["logging.go"],
+    importpath = "github.com/sourcegraph/sourcegraph/dev/linters/logging",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//dev/linters/nolint",
+        "@com_github_openpeedeep_depguard_v2//:go_default_library",
+        "@org_golang_x_tools//go/analysis",
+    ],
+)

dev/linters/logging/logging.go

@@ -0,0 +1,45 @@
+package logging
+
+import (
+	"fmt"
+
+	"github.com/OpenPeeDeeP/depguard/v2"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/sourcegraph/sourcegraph/dev/linters/nolint"
+)
+
+// This analyzer is modeled after the one in
+// https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph@f6ae87add606c65876b87d378929fcb80c3bb493/-/blob/dev/linters/depguard/depguard.go
+// These could potentially be combined into one analyzer.
+var Analyzer *analysis.Analyzer = createAnalyzer()
+
+const useLogInsteadMessage = `use "github.com/sourcegraph/log" instead`
+
+// Deny is a map which contains all the deprecated logging packages
+// The key of the map is the package name that is not allowed - globs can be used as keys.
+// The value of the key is the reason to give as to why the logger is not allowed.
+var Deny = map[string]string{
+	"log$":                              useLogInsteadMessage,
+	"github.com/inconshreveable/log15$": useLogInsteadMessage,
+	"go.uber.org/zap":                   useLogInsteadMessage,
+}
+
+func createAnalyzer() *analysis.Analyzer {
+	settings := &depguard.LinterSettings{
+		"deprecated loggers": &depguard.List{
+			Deny: Deny,
+			Files: []string{
+				// Let everything in dev use whatever they want
+				"!**/dev/**/*.go",
+			},
+		},
+	}
+	analyzer, err := depguard.NewAnalyzer(settings)
+	if err != nil {
+		panic(fmt.Sprintf("failed to create deprecated logging analyzer: %v", err))
+	}
+	analyzer.Name = "logging"
+
+	return nolint.Wrap(analyzer)
+}

internal/auth/providers/providers.go

@@ -7,7 +7,7 @@ import (
 	"sort"
 	"sync"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/extsvc"
 	"github.com/sourcegraph/sourcegraph/schema"

internal/authz/providers/bitbucketserver/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

internal/authz/providers/gitlab/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

internal/authz/providers/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

internal/authz/providers/perforce/main_test.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 )
 
 func TestMain(m *testing.M) {

internal/batches/reconciler/executor.go

@@ -9,7 +9,7 @@ import (
 	"text/template"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/sourcegraph/log"
 
 	bgql "github.com/sourcegraph/sourcegraph/internal/batches/graphql"

internal/batches/scheduler/scheduler.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/batches/store"
 	"github.com/sourcegraph/sourcegraph/internal/batches/types/scheduler/config"

internal/batches/scheduler/ticker.go

@@ -3,7 +3,7 @@ package scheduler
 import (
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/batches/types/scheduler/window"
 	"github.com/sourcegraph/sourcegraph/internal/goroutine"

internal/batches/sources/bitbucketserver.go

@@ -5,7 +5,7 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	btypes "github.com/sourcegraph/sourcegraph/internal/batches/types"
 

internal/batches/sources/bitbucketserver_test.go

@@ -7,7 +7,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/stretchr/testify/assert"
 
 	btypes "github.com/sourcegraph/sourcegraph/internal/batches/types"

internal/batches/sources/gitlab_test.go

@@ -11,7 +11,7 @@ import (
 
 	"github.com/Masterminds/semver"
 	"github.com/google/go-cmp/cmp"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/stretchr/testify/assert"
 
 	btypes "github.com/sourcegraph/sourcegraph/internal/batches/types"

internal/batches/sources/main_test.go

@@ -12,7 +12,7 @@ import (
 	"github.com/dnaeon/go-vcr/cassette"
 	"github.com/dnaeon/go-vcr/recorder"
 	"github.com/grafana/regexp"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/extsvc"
 	"github.com/sourcegraph/sourcegraph/internal/httpcli"

internal/batches/state/changeset_history.go

@@ -4,7 +4,7 @@ import (
 	"sort"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	adobatches "github.com/sourcegraph/sourcegraph/internal/batches/sources/azuredevops"
 	gerritbatches "github.com/sourcegraph/sourcegraph/internal/batches/sources/gerrit"

internal/batches/types/changeset.go

@@ -8,7 +8,7 @@ import (
 	"time"
 
 	"github.com/goware/urlx"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/sourcegraph/go-diff/diff"
 
 	"github.com/sourcegraph/sourcegraph/internal/api"

internal/batches/types/changeset_event.go

@@ -8,7 +8,7 @@ import (
 
 	"github.com/sourcegraph/sourcegraph/internal/extsvc/azuredevops"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/extsvc/bitbucketcloud"
 	"github.com/sourcegraph/sourcegraph/internal/extsvc/bitbucketserver"

internal/batches/types/scheduler/config/config.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"sync"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/batches/types/scheduler/window"
 	"github.com/sourcegraph/sourcegraph/internal/conf"

internal/cmd/ghe-feeder/main.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"flag"
 	"fmt"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"math"
 	"net/http"
 	"net/url"
@@ -14,7 +14,7 @@ import (
 	"sync"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promauto"
 	"github.com/prometheus/client_golang/prometheus/promhttp"

internal/cmd/ghe-feeder/progress.go

@@ -4,7 +4,7 @@ import (
 	"database/sql"
 	"sync"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	_ "github.com/mattn/go-sqlite3"
 
 	"github.com/sourcegraph/sourcegraph/internal/database/dbutil"

internal/cmd/ghe-feeder/pump.go

@@ -9,7 +9,7 @@ import (
 	"path/filepath"
 	"strings"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/schollz/progressbar/v3"
 )

internal/cmd/ghe-feeder/worker.go

@@ -12,7 +12,7 @@ import (
 	"time"
 
 	"github.com/google/go-github/v55/github"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/schollz/progressbar/v3"
 	"golang.org/x/oauth2"

internal/cmd/git-combine/BUILD.bazel

@@ -1,5 +1,5 @@
-load("//dev:go_defs.bzl", "go_test")
 load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("//dev:go_defs.bzl", "go_test")
 
 go_library(
     name = "git-combine_lib",

internal/cmd/git-combine/git-combine.go

@@ -5,7 +5,7 @@ import (
 	"fmt"
 	"hash/crc32"
 	"io/fs"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"math"
 	"math/rand"
 	"os"

internal/cmd/init-sg/main.go

@@ -5,7 +5,7 @@ import (
 	"flag"
 	"fmt"
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"strings"
 	"time"

internal/cmd/jsonc-validate/main.go

@@ -2,7 +2,7 @@ package main
 
 import (
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 
 	"github.com/sourcegraph/sourcegraph/internal/jsonc"

internal/cmd/progress-bot/main.go

@@ -13,7 +13,7 @@ import (
 	"image/color"
 	"image/png"
 	"io"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"net/http"
 	"os"
 	"sort"

internal/cmd/search-blitz/main.go

@@ -14,7 +14,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	"gopkg.in/natefinch/lumberjack.v2"
 )

internal/cmd/tracking-issue/main.go

@@ -5,7 +5,7 @@ package main
 import (
 	"context"
 	"flag"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"strings"
 

internal/conf/computed.go

@@ -2,7 +2,7 @@ package conf
 
 import (
 	"encoding/hex"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"strings"
 	"time"
 

internal/conf/conf.go

@@ -3,7 +3,7 @@ package conf
 
 import (
 	"context"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"os"
 	"path/filepath"
 	"strings"

internal/conf/reposource/custom.go

@@ -5,7 +5,7 @@ import (
 	"strings"
 
 	"github.com/grafana/regexp"
-	"github.com/inconshreveable/log15"
+	"github.com/inconshreveable/log15" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/api"
 	"github.com/sourcegraph/sourcegraph/internal/conf"

internal/conf/service_watcher.go

@@ -1,7 +1,7 @@
 package conf
 
 import (
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 
 	"github.com/sourcegraph/sourcegraph/internal/conf/conftypes"
 )

internal/database/dbconn/open.go

@@ -5,7 +5,7 @@ import (
 	"database/sql"
 	"database/sql/driver"
 	"fmt"
-	"log"
+	"log" //nolint:logging // TODO move all logging to sourcegraph/log
 	"strconv"
 	"strings"
 	"sync"