artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 20:51:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
0777ced17f
sourcegraph/internal
History
Aditya Kalia 0777ced17f
V2-telemetry: Simplify sensitive metadata allowlist to accept feature only (#63325) 
This PR adds another option to the sensitive metadata allowlist by
simplifying the input requirements. to accept `feature` and the
allowlisted `privateMetadata` keys for that feature.

This change is particularly beneficial when a `feature` has multiple
associated `action`(s), and the `privateMetadata` key needs to be
allowed for all events related to that feature.

Building upon this initial PR:
- https://github.com/sourcegraph/sourcegraph/pull/62830/files

<!-- 💡 To write a useful PR description, make sure that your description
covers:
- WHAT this PR is changing:
    - How was it PREVIOUSLY.
    - How it will be from NOW on.
- WHY this PR is needed.
- CONTEXT, i.e. to which initiative, project or RFC it belongs.

The structure of the description doesn't matter as much as covering
these points, so use
your best judgement based on your context.
Learn how to write good pull request description:
https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e?pvs=4
-->


## Test plan

<!-- All pull requests REQUIRE a test plan:
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles
-->
CI and unit tests

## Changelog

<!--
1. Ensure your pull request title is formatted as: $type($domain): $what
2. Add bullet list items for each additional detail you want to cover
(see example below)
3. You can edit this after the pull request was merged, as long as
release shipping it hasn't been promoted to the public.
4. For more information, please see this how-to
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c?

Audience: TS/CSE > Customers > Teammates (in that order).

Cheat sheet: $type = chore|fix|feat $domain:
source|search|ci|release|plg|cody|local|...
-->

<!--
Example:

Title: fix(search): parse quotes with the appropriate context
Changelog section:

## Changelog

- When a quote is used with regexp pattern type, then ...
- Refactored underlying code.
-->
2024-06-27 15:22:58 -04:00
..
accesstoken bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
actor bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
adminanalytics bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
api chore: Use new cmp package to simplify comparisons (#63029) 2024-06-03 19:44:48 +08:00
appliance chore(appliance): extract layout template (#63467) 2024-06-25 15:34:46 +01:00
audit bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
auth internal/telemetry: make adding EventsStore middleware easier (#63216) 2024-06-13 11:55:06 +01:00
authbearer bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
authz dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
batches fix(batch-changes): remove leading and trailing spaces from batch changes credentials (#63517) 2024-06-27 10:32:08 -05:00
binary
bytesize bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
byteutils bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
cloud bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
cmd chore(tooling): bump Go version to 1.22.4 (#63124) 2024-06-06 15:19:03 +00:00
codeintel dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
codemonitors bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
codygateway feat/cody-gateway: use Enterprise Portal for actor/productsubscriptions (#62934) 2024-06-07 11:46:01 -07:00
collections chore: Add collection type - OrderedSet (#63469) 2024-06-25 13:13:14 +00:00
comby bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
completions test(cody): Add unit tests for the Completions API (#63434) 2024-06-23 14:11:58 -07:00
compute chore: Centralize languages package as source-of-truth (#63292) 2024-06-18 13:10:24 +00:00
conf support fast, simple sg start single-program-experimental-blame-sqs for local dev (#63435) 2024-06-24 21:12:47 +00:00
cookie bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
ctags_config bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
database dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
debugserver chore/deps: upgrade grpc, prometheus/common (#63328) 2024-06-19 09:55:44 -04:00
deviceid
diskcache all: use observation.TestContextTB instead of TestContext (#61751) 2024-04-10 14:07:39 +02:00
diskusage bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
dotcom dotcom: MockSourcegraphDotComMode requires a T for cleanup (#61172) 2024-03-14 20:27:21 +00:00
download
embeddings bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
encryption bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
endpoint bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
env Cleanup internalapi after gRPC migration (#60572) 2024-02-19 14:13:26 +01:00
errcode dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
eventlogger bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
executor worker: Reduce frequency of very frequently run jobs (#62864) 2024-05-23 18:31:20 +02:00
extsvc fix(batch-changes): disallow retry on deleted changesets (#63336) 2024-06-20 08:07:57 -05:00
featureflag Feature flags: relax some constraints (#61343) 2024-03-25 10:39:01 -06:00
fileutil gitserver: Implement RefHash in backend (#62612) 2024-05-13 16:05:16 +02:00
github_apps bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
gitserver chore: Add doc comment for DiffOptions.Paths (#63385) 2024-06-20 19:26:34 +08:00
goroutine lib/background: upgrade Routine interface with context and errors (#62136) 2024-05-24 10:04:55 -04:00
gosyntect feat(search): Add Syntax Highlighting for Magik language (#62919) 2024-06-06 16:49:07 -04:00
gqltestutil Search: expose path matches on FileMatch (#63396) 2024-06-26 08:23:28 -06:00
gqlutil
grpc chore/deps: upgrade grpc, prometheus/common (#63328) 2024-06-19 09:55:44 -04:00
guardrails bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
hashutil
highlight chore(search): Add test case covering hack lang detection behavior (#63136) 2024-06-07 09:35:39 -04:00
honey honey: add read locking to event.Fields call for NonSendingReader (#61886) 2024-04-15 15:19:38 +00:00
hostmatcher gomod: update or vendor buildkit, docker, hostmatcher and saml to resolve CVEs (#60130) 2024-02-05 13:14:15 +02:00
hostname
htmlutil Web: add mermaid diagram rendering (#62678) 2024-05-16 14:54:43 -04:00
httpcli httpcli: Remove useless err check (#62321) 2024-05-02 19:22:43 +02:00
httpserver lib/background: upgrade Routine interface with context and errors (#62136) 2024-05-24 10:04:55 -04:00
httptestutil Remove GitHub proxy service (#56485) 2023-09-14 19:43:40 +02:00
insights dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
instrumentation chore: upgrade otel SDK packages (#59564) 2024-01-15 20:08:54 +00:00
ipynb Render Jupyter notebooks (#62583) 2024-05-10 12:21:10 -04:00
jsonc
k8s/resource feat(appliance): local developer mode (#63417) 2024-06-24 16:19:27 +01:00
lazyregexp
license bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
licensing chore: Change errors.HasType to respect multi-errors (#63024) 2024-06-06 13:02:14 +00:00
limiter bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
logging fix: update links for dev docs (#62758) 2024-05-17 13:47:34 +02:00
luasandbox bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
mapfs bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
maps Revert "Remove unused internal/k8s package" (#61835) 2024-04-12 09:35:40 -04:00
markdown Render Jupyter notebooks (#62583) 2024-05-10 12:21:10 -04:00
memcmd fix/internal/memcmd: close the explicit stop channel before cancelling context (#63214) 2024-06-12 06:08:29 -07:00
memo
metrics chore/deps: upgrade grpc, prometheus/common (#63328) 2024-06-19 09:55:44 -04:00
modelconfig config(cody): Various fixes and updating the naming rules for ModelConfig resource IDs (#63436) 2024-06-24 10:37:49 -07:00
notebooks bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
oauthtoken bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
oauthutil bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
observation chore: Simplify RequestState/PositionalRequestArgs o11y code (#63040) 2024-06-04 18:08:48 +08:00
oobmigration lib/background: upgrade Routine interface with context and errors (#62136) 2024-05-24 10:04:55 -04:00
opencodegraph fix: update links for dev docs (#62758) 2024-05-17 13:47:34 +02:00
otlpenv
own gitserver: Add CommitLog API to replace client-side Commits (#62606) 2024-05-21 15:21:58 +02:00
packagefilters bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
paths Replace all traditional for-loops (#60988) 2024-03-11 16:05:47 +02:00
pbt chore(codenav): Resolve repo and commit in common code (#63072) 2024-06-07 21:58:36 +08:00
perforce bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
productsubscription bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
profiler bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
pubsub lib/background: upgrade Routine interface with context and errors (#62136) 2024-05-24 10:04:55 -04:00
randstring Replace all traditional for-loops (#60988) 2024-03-11 16:05:47 +02:00
ratelimit chore: Change errors.HasType to respect multi-errors (#63024) 2024-06-06 13:02:14 +00:00
rbac bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
rcache enterprise-portal: init database schema and handler store (#63139) 2024-06-06 18:54:12 -04:00
redislock enterprise-portal: implement basic MSP IAM and RPCs (#63173) 2024-06-19 21:46:48 -04:00
redispool chore: Remove dead code (#61899) 2024-04-16 10:17:47 +02:00
releaseregistry fix(appliance): source versions from release registry (#63387) 2024-06-24 09:48:50 +00:00
repos dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
repoupdater dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
requestclient Replace all traditional for-loops (#60988) 2024-03-11 16:05:47 +02:00
requestinteraction requestinteraction: add X-Sourcegraph-Interaction-ID propagation (#58016) 2023-11-22 20:09:39 +00:00
rockskip rockskip: Replace second long-running process with gRPC API (#62734) 2024-05-21 17:45:27 +02:00
sams bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
sanitycheck
search chore: Bump go-enry and Zoekt to handle new languages (#63281) 2024-06-20 22:19:39 +08:00
searcher bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
security bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
service support fast, simple sg start single-program-experimental-blame-sqs for local dev (#63435) 2024-06-24 21:12:47 +00:00
session chore: Change errors.HasType to respect multi-errors (#63024) 2024-06-06 13:02:14 +00:00
settings Chore: remove search console (#63322) 2024-06-19 11:05:03 -06:00
siteid bazel: first pass at moving moving logging linting into nogo (#58910) 2024-01-02 10:07:25 -08:00
slack
sourcegraphoperator bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
src-cli Bump minimum src-cli version required (#62700) 2024-05-16 09:52:46 +00:00
src-prometheus fix: update links for dev docs (#62758) 2024-05-17 13:47:34 +02:00
suspiciousnames bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
symbols bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
sysreq
telemetry V2-telemetry: Simplify sensitive metadata allowlist to accept feature only (#63325) 2024-06-27 15:22:58 -04:00
telemetrygateway chore/deps: upgrade grpc, prometheus/common (#63328) 2024-06-19 09:55:44 -04:00
temporarysettings
testutil build-tracker: fix convenience urls in env (#62340) 2024-05-01 14:26:34 +00:00
timeutil
trace chore: Break dependency of internal/trace on conf (#62177) 2024-04-30 21:12:39 +02:00
tracer chore: Break dependency of internal/trace on conf (#62177) 2024-04-30 21:12:39 +02:00
ttlcache bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
txemail bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
types dotcom: Remove on-demand cloning of repositories (#63321) 2024-06-26 14:53:14 -07:00
unpack
updatecheck bug(release): update hard coded consts (#63133) 2024-06-06 13:16:36 -07:00
uploadhandler chore: Enable traces for uploads (#63025) 2024-06-03 04:17:50 -07:00
uploadstore chore: Change errors.HasType to respect multi-errors (#63024) 2024-06-06 13:02:14 +00:00
usagestats fix: update links for dev docs (#62758) 2024-05-17 13:47:34 +02:00
users scim: Fix user updates when SCIM was previously enabled (#63135) 2024-06-06 22:24:00 +02:00
vcs bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
version bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
webhooks/outbound bazel: transcribe test ownership to bazel tags (#62664) 2024-05-16 15:51:16 +01:00
workerutil lib/background: upgrade Routine interface with context and errors (#62136) 2024-05-24 10:04:55 -04:00
wrexec wrexec: Don't panic when process state is nil (#57610) 2023-10-16 23:40:16 +02:00
buf.yaml
BUILD.bazel