Commit Graph

19522 Commits

Author SHA1 Message Date
Rijnard van Tonder
f0ca58171f
compute: add notebook block component (#32290) 2022-03-09 17:38:35 -08:00
Camden Cheek
154ca95e7c
Search: break dependencies on pre-formatted markdown (#32346)
Currently, for commit matches, we generate label and detail in the backend as markdown-formatted strings. This adds the information needed to generate these fields to the commit match stream type cuts markdown out of the loop.
2022-03-09 19:08:45 -06:00
Robert Lin
7c8091d234
doc/dev: update feature flags guide to reference site admin UI (#32411) 2022-03-09 16:31:08 -08:00
Juliana Peña
9699b27c15
code monitoring: enable logs for everyone as beta feature (#32292)
* code monitoring: enable logs for everyone as beta feature

* update changelog
2022-03-09 15:18:22 -08:00
Stephen Gutekanst
7f6f953fa3
graphqlbackend: initial on-prem user invites collaborator discovery backend (#31968)
* graphqlbackend: initial on-prem user invites collaborator discovery backend

This is the initial backend for on-prem user invites' collaborator discovery.

Unlike the one we use for Cloud signup, which uses the GitHub API to find
collaborators (because the repos are not yet cloned on Sourcegraph), this API
leverages gitserver instead since the repositories are cloned. We look at recent
committers from 25 of the users' most starred repositories.

This is quite fast, completing in under a few hundred milliseconds.

One drawback here, however, is that we do not get profile pictures currently.
Because these users do not exist on Sourcegraph, and we only have their email
address, we don't have any simple way to get their profile picture. The GitHub API
is not suitable for fetching this information, either, and so instead we fallback to Gravatar
images which are better than nothing.

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
2022-03-09 22:51:23 +00:00
Cristina Birkel
86af32ba09
insights: Fix dashboard ping, coalesce all values with 0 in case of nulls (#32408) 2022-03-09 17:10:30 -05:00
Juliana Peña
23ac4d1798
code monitors: action cancel button doesn't undo changes (#32227) 2022-03-09 13:23:38 -08:00
Robert Lin
c1f40062f0
site-admin: create, update, and delete feature flags (#32246)
Co-authored-by: Erik Seliger <erikseliger@me.com>
2022-03-09 12:23:31 -08:00
Michael Lin
f92c72fe33
doc: update syntax-highlighter scalability info (#32359) 2022-03-09 20:23:16 +00:00
Chris Wendt
c4d4caa65b
rockskip: Optimize case insensitive queries (#32356) 2022-03-09 11:21:25 -07:00
coury-clark
45408e7923
Insights: garbage collect unused insight data (time series and metadata) (#32094) 2022-03-09 10:58:54 -07:00
Kelli Rockwell
2bfac7a91d
Wildcard V2: Introduce MultiSelect (#32103) 2022-03-09 09:56:19 -08:00
Robert Lin
3c1d6c681e
dev/ci: fix backcompat annotations (#32400) 2022-03-09 09:47:55 -08:00
Robert Lin
798e09b86d
authz/github: allow list group repos 404 to persist to cache (#32357)
Potential solution to sourcegraph/customer#742 . Looks like GitHub has some odd behaviours related to teams called owners etc. that may cause "list repo" on an existing repo to return 404. A 404 is not transient, and retrying on a 404 will not make it un-404, so we allow these errors to persist to cache. I've added a docstring inline to explain why this is safe.

Co-authored-by: Molly Weitzel <molly.weitzel@sourcegraph.com>
2022-03-09 09:20:14 -08:00
Robert Lin
44bc5c461f
.github: note that a test plan can be explanation (#32397) 2022-03-09 09:16:42 -08:00
Asdine El Hrychy
c8221d8a9c
gitserver-store: add SetRepoSize method (#32369) 2022-03-09 20:17:51 +04:00
GitStart-SourceGraph
0570c5ae57
wildcard/Icon migration on client/enterprise
Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
2022-03-09 23:15:08 +07:00
sourcegraph-buildkite
a001174ced
zoekt: update to sourcegraph/zoekt@eba22ccc3c (#32388)
Co-authored-by: davejrt <davejrt@users.noreply.github.com>
2022-03-09 17:00:32 +01:00
Philipp Spiess
0cec9856b1
Remove server with contributors story until we ship contributors for server (#32365) 2022-03-09 16:47:55 +01:00
Jean-Hadrien Chabran
072969e280
sg: fix lint command subcommands (#32381) 2022-03-09 16:10:09 +01:00
Ryan Slade
cac1e166a3
database: Remove more uses of Mocks.ExternalServices (#32384)
Removed all uses outside of the database package.
Unexported it.
Removed all the mock fields apart from List as they weren't being used.

The final left over usages can be removed in another PR and are a bit
tricker since they are called from within another method on the
ExternalServiceStore interface.
2022-03-09 15:46:37 +01:00
Asdine El Hrychy
0235057f9f
gitserver-store: add support for repo_size_bytes (#32364) 2022-03-09 18:35:45 +04:00
Vova Kulikov
98f588a4f4
Code Insights: Add "Remove insight from dashboard" context menu action (#32327)
* Extend API with remove insight method

* Add use insight remove hook

* Extend insight UI with remove from the dashboard action

* Fix gql query types generation

* Fix the main dashboard page padding problem

* Fix insight context menu layout and styles

* Fix position for the menu list popover

* Remove unused styles CSS class
2022-03-09 18:22:01 +04:00
Quinn Keast
cd0799fa36
Update spacing following h4s in notices (#32371) 2022-03-09 15:14:28 +01:00
Vova Kulikov
318a6d6476
Code Insights: Fix insight tooltip overflow layout problem (#32331)
* Fix tooltip text overflow problem

* Fix legend items overflow layout problem
2022-03-09 16:48:01 +04:00
Jean-Hadrien Chabran
e3e69376b2
Add a ready mechanism to the conf pkg (#32265)
Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
Co-authored-by: vrto <michal.vrtiak@sourcegraph.com>
2022-03-09 13:33:45 +01:00
Jean-Hadrien Chabran
ff6a260bb1
sg: add an audit command to display prs trail (#32347)
This is a first iteration that simply outputs a report of the issues in
either markdown or text format of the issues created by missing test
plans or reviews.

The plan is to automate it as we refine the process in the upcoming
weeks.

Co-authored-by: Robert Lin <robert@bobheadxi.dev>
2022-03-09 12:22:34 +00:00
Mariam Adedeji
487a4124e1
Update troubleshoot-sg-extension.md (#32001) 2022-03-09 11:55:42 +00:00
Erzhan Torokulov
1b559a7284
Enable/rollout "Getting started tour for visitors" on dotcom mode (#32263)
* Add "TourShown", "TourClosed" and "TourRestartClicked" event logs
* Update "Get started" button link to open on a new tab
* Rename "onboarding tour" prefix to "getting started tour" to avoid confusion w/ other search onboarding tour
* Cleanup old "search-notebook-onboarding" experiment
* Update CHANGELOG.md
2022-03-09 16:30:16 +06:00
Asdine El Hrychy
ccd7421113
gitserver: Add repo_size_bytes column to the gitserver_repos table (#32325) 2022-03-09 11:30:59 +04:00
Michelle Veronese
48d2b88190
Add backend changes to allow hard deleting orgs on Cloud (#32355)
* Add initial funcion and mutation for hard deleting an org - wip

* Add feature flag

* Fix wrong import

* Remove debug message

* Delete notebooks and settings before deleting an org

* Define removeOrganization in the schema.graphql instead of in org/backend.ts

* Clean some degug messages

* Only clean settings for On-prem

* Switch back to returning error when new feature flag is false

* Add some tests

* Add extra checks and more tests

* Update mocks, fix message

* Add test for happy path, fix wrong db variable that make mock fail

* Address PR reviewers suggestions - part 1

* Add missing manual deletion for the case where we don't have On Delete Cascade

* Remove debug message

* Check if org exists before running any query

* Edit error message

* Address more suggestions from the PR reviewers

* Avoid repeting so many delete statements

* Remove debug messages

* Use deleteOrganization and add a new arg to it instead of creating a new function

* Remove leftover

* Use sqlf.Sprintf and add security comment

* Regenerate mocks

* Re-re-generate mocks

* Use helper methods for soft/hard delete, update unit tests

* Unmarshal orgID only if user can soft delete org
2022-03-08 19:38:15 -08:00
Justin Boyson
96918ef375
Jdb/add-ui-features-hook (#32184)
* add useUiFeaturesHook
* stub out backend features support
2022-03-09 01:09:54 +00:00
Justin Boyson
4318b968d4
Add failure mode for "no configured mock response" (#32358) 2022-03-08 16:33:06 -08:00
Chris Wendt
8d47b9d509
symbols: Fix columns (#32299) 2022-03-08 23:40:13 +00:00
sourcegraph-buildkite
f0b5b3651d
zoekt: update to sourcegraph/zoekt@10a1f8a8d4 (#32298)
Co-authored-by: tsenart <tsenart@users.noreply.github.com>
2022-03-08 16:34:51 -05:00
Joel Kwartler
7f903b47b3
update best practices for large repository insights (#32350) 2022-03-08 13:02:23 -08:00
Michelle Veronese
e416f9948f
Revert "Add functionality and feature flag to allow hard deleting organizations (#31528)" (#32351)
This reverts commit f079d257de.
2022-03-08 12:22:27 -08:00
Chris Wendt
89ca47e559
symbols: Key on version directory (#32300) 2022-03-08 19:17:26 +00:00
Chris Wendt
bfd8245309
diskcache: Refactor EncodeKeyComponents (#32301) 2022-03-08 12:08:07 -07:00
Camden Cheek
ba1e08e495
Search backend: remove unused settings field (#32297) 2022-03-08 18:47:14 +00:00
Michelle Veronese
f079d257de
Add functionality and feature flag to allow hard deleting organizations (#31528)
* Add initial funcion and mutation for hard deleting an org - wip

* Add feature flag

* Fix wrong import

* Remove debug message

* Delete notebooks and settings before deleting an org

* Define removeOrganization in the schema.graphql instead of in org/backend.ts

* Clean some degug messages

* Only clean settings for On-prem

* Switch back to returning error when new feature flag is false

* Add some tests

* Add extra checks and more tests

* Update mocks, fix message

* Add test for happy path, fix wrong db variable that make mock fail

* Address PR reviewers suggestions - part 1

* Add missing manual deletion for the case where we don't have On Delete Cascade

* Remove debug message

* Check if org exists before running any query

* Edit error message

* Address more suggestions from the PR reviewers

* Avoid repeting so many delete statements

* Remove debug messages

* Use deleteOrganization and add a new arg to it instead of creating a new function

* Remove leftover

* Use sqlf.Sprintf and add security comment

* Regenerate mocks

* Re-re-generate mocks

* Use helper methods for soft/hard delete, update unit tests
2022-03-08 10:44:26 -08:00
Jean-Hadrien Chabran
0f03638478
ci: fix missing ci docs update (#32339) 2022-03-08 18:44:31 +01:00
Jean-Hadrien Chabran
6baf52289f
ci: ship sg image without deploy (#32334) 2022-03-08 17:07:51 +00:00
Ryan Slade
a6bdabbe9f
batches: Remove use of database.Mocks.ExternalServices (#32333) 2022-03-08 18:01:21 +01:00
Philipp Spiess
b3a7ad52f4
Do not show IDE CTAs to users who have these products installed (#32209)
* Detect IDE extension usage and store the results in a user's temporary settings

* Add test and document working URLs

* Fix failing tests

* Use React Router for location detection and proper temporary settings test utils

* Remove workaround for unstable temporary settings updater (requires #32266)

* Remove leftover && true

* Change deps array
2022-03-08 17:33:33 +01:00
Philipp Spiess
5e2eb3e5aa
Fix unnecessary recreation of temporary settings hook updater callback (#32266)
* Fix unnecessary recreation of temporary settings hook updater callback

* Retrigger CI
2022-03-08 17:32:17 +01:00
Philipp Spiess
4d461bfb73
user invites: Disable user invites when instance signup is disabled and on on-prem (#32273)
* user invites: Disable user invites when instance signup is disabled

* Require dot com mode

* Fix tests

* Fix storybook tests
2022-03-08 17:31:38 +01:00
Cristina Birkel
f278b46c36
insights: Add more backend pings to docs (#32092) 2022-03-08 11:03:35 -05:00
Cristina Birkel
9b07822564
insights: Add 4 new backend dashboard pings (#31901) 2022-03-08 11:03:10 -05:00
Jean-Hadrien Chabran
96676ccf62
sg: add Dockerfile and build script (#32326) 2022-03-08 16:54:50 +01:00