artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 18:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Accessibility: Update FilteredConnection to support better usage of labels (#36643)

Browse Source
This commit is contained in:
Tom Ross 2022-06-06 14:30:12 +01:00 committed by GitHub
parent 8b4d7d5b2e
commit 75dba9b79c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/web/src/components/FilteredConnection/FilteredConnection.tsx
View File

@ -483,6 +483,8 @@ export class FilteredConnection<
// this.state.connectionOrError.nodes.length > 0 &&
// this.props.hideControlsWhenEmpty
const inputPlaceholder = this.props.inputPlaceholder || `Search ${this.props.pluralNoun}...`
return (
<ConnectionContainer compact={this.props.compact} className={this.props.className}>
{
@ -491,8 +493,8 @@ export class FilteredConnection<
ref={this.setFilterRef}
hideSearch={this.props.hideSearch}
inputClassName={this.props.inputClassName}
inputPlaceholder={this.props.inputPlaceholder || `Search ${this.props.pluralNoun}...`}
inputAriaLabel={this.props.inputAriaLabel}
inputPlaceholder={inputPlaceholder}
inputAriaLabel={this.props.inputAriaLabel || inputPlaceholder}
inputValue={this.state.query}
onInputChange={this.onChange}
autoFocus={this.props.autoFocus}

1
client/web/src/repo/releases/__snapshots__/RepositoryReleasesTagsPage.test.tsx.snap
View File

@ -16,6 +16,7 @@ exports[`RepositoryReleasesTagsPage renders 1`] = `
class="container loader-input loaderInput input"
>
<input
aria-label="Search tags..."
autocapitalize="off"
autocomplete="off"
autocorrect="off"