diff --git a/client/web/src/components/FilteredConnection/FilteredConnection.tsx b/client/web/src/components/FilteredConnection/FilteredConnection.tsx index 2c2876979c1..8e268b32d48 100644 --- a/client/web/src/components/FilteredConnection/FilteredConnection.tsx +++ b/client/web/src/components/FilteredConnection/FilteredConnection.tsx @@ -483,6 +483,8 @@ export class FilteredConnection< // this.state.connectionOrError.nodes.length > 0 && // this.props.hideControlsWhenEmpty + const inputPlaceholder = this.props.inputPlaceholder || `Search ${this.props.pluralNoun}...` + return ( { @@ -491,8 +493,8 @@ export class FilteredConnection< ref={this.setFilterRef} hideSearch={this.props.hideSearch} inputClassName={this.props.inputClassName} - inputPlaceholder={this.props.inputPlaceholder || `Search ${this.props.pluralNoun}...`} - inputAriaLabel={this.props.inputAriaLabel} + inputPlaceholder={inputPlaceholder} + inputAriaLabel={this.props.inputAriaLabel || inputPlaceholder} inputValue={this.state.query} onInputChange={this.onChange} autoFocus={this.props.autoFocus} diff --git a/client/web/src/repo/releases/__snapshots__/RepositoryReleasesTagsPage.test.tsx.snap b/client/web/src/repo/releases/__snapshots__/RepositoryReleasesTagsPage.test.tsx.snap index 7e8c96591ef..4e13e29a78d 100644 --- a/client/web/src/repo/releases/__snapshots__/RepositoryReleasesTagsPage.test.tsx.snap +++ b/client/web/src/repo/releases/__snapshots__/RepositoryReleasesTagsPage.test.tsx.snap @@ -16,6 +16,7 @@ exports[`RepositoryReleasesTagsPage renders 1`] = ` class="container loader-input loaderInput input" >