From afa95ae059632d478eb236e2c5f0bf666f6f7689 Mon Sep 17 00:00:00 2001
From: WHYTEWYLL <juanmiblanco1@gmail.com>
Date: Tue, 5 Dec 2023 18:45:38 -0300
Subject: [PATCH] add: column in gold view

---
 models/descriptions/tx_status.md                           | 2 +-
 models/descriptions/tx_succeeded.md                        | 5 +++++
 models/gold/core/core__fact_transactions.sql               | 1 +
 models/gold/core/core__fact_transactions.yml               | 7 +++++++
 .../streamline/silver__streamline_transactions_final.sql   | 2 +-
 5 files changed, 15 insertions(+), 2 deletions(-)
 create mode 100644 models/descriptions/tx_succeeded.md

diff --git a/models/descriptions/tx_status.md b/models/descriptions/tx_status.md
index 7f9c336..314dd73 100644
--- a/models/descriptions/tx_status.md
+++ b/models/descriptions/tx_status.md
@@ -1,5 +1,5 @@
 {% docs tx_status %}
 
-Indicates whether the transaction failed or succeeded.
+/// DEPRECATION WARNING /// Indicates whether the transaction failed or succeeded. This will be get deprecated in the future. Please use `tx_succeeded` instead.
 
 {% enddocs %}
diff --git a/models/descriptions/tx_succeeded.md b/models/descriptions/tx_succeeded.md
new file mode 100644
index 0000000..96d45c7
--- /dev/null
+++ b/models/descriptions/tx_succeeded.md
@@ -0,0 +1,5 @@
+{% docs tx_succeeded %}
+
+Indicates whether the transaction failed or succeeded.
+
+{% enddocs %}
diff --git a/models/gold/core/core__fact_transactions.sql b/models/gold/core/core__fact_transactions.sql
index 7bc59ad..7d4850a 100644
--- a/models/gold/core/core__fact_transactions.sql
+++ b/models/gold/core/core__fact_transactions.sql
@@ -24,6 +24,7 @@ SELECT
     gas_used,
     transaction_fee,
     attached_gas,
+    tx_succeeded,
     tx_status
 FROM
     transactions
diff --git a/models/gold/core/core__fact_transactions.yml b/models/gold/core/core__fact_transactions.yml
index 7f03b57..e711047 100644
--- a/models/gold/core/core__fact_transactions.yml
+++ b/models/gold/core/core__fact_transactions.yml
@@ -109,6 +109,13 @@ models:
                 - NUMBER
                 - FLOAT
 
+      - name: tx_succeeded
+        description: "{{ doc('tx_succeeded')}}"
+        tests:
+          - dbt_expectations.expect_column_values_to_be_in_type_list:
+              column_type_list:
+                - BOOLEAN
+
       - name: TX_STATUS
         description: "{{ doc('tx_status')}}"
         tests:
diff --git a/models/silver/streamline/silver__streamline_transactions_final.sql b/models/silver/streamline/silver__streamline_transactions_final.sql
index ffc4688..67791e6 100644
--- a/models/silver/streamline/silver__streamline_transactions_final.sql
+++ b/models/silver/streamline/silver__streamline_transactions_final.sql
@@ -152,7 +152,7 @@ receipts AS (
       ORDER BY
         tx_hash DESC
     ) AS receipt_tokens_burnt,
-    execution_outcome :outcome: tokens_burnt AS tokens_burnt
+    execution_outcome :outcome: tokens_burnt :: NUMBER AS tokens_burnt
   FROM
     int_receipts
   WHERE