mirror of
https://github.com/FlipsideCrypto/dcrd.git
synced 2026-02-06 10:56:47 +00:00
This commit is the first stage of several that are planned to convert
the blockchain package into a concurrent safe package that will
ultimately allow support for multi-peer download and concurrent chain
processing. The goal is to update btcd proper after each step so it can
take advantage of the enhancements as they are developed.
In addition to the aforementioned benefit, this staged approach has been
chosen since it is absolutely critical to maintain consensus.
Separating the changes into several stages makes it easier for reviewers
to logically follow what is happening and therefore helps prevent
consensus bugs. Naturally there are significant automated tests to help
prevent consensus issues as well.
The main focus of this stage is to convert the blockchain package to use
the new database interface and implement the chain-related functionality
which it no longer handles. It also aims to improve efficiency in
various areas by making use of the new database and chain capabilities.
The following is an overview of the chain changes:
- Update to use the new database interface
- Add chain-related functionality that the old database used to handle
- Main chain structure and state
- Transaction spend tracking
- Implement a new pruned unspent transaction output (utxo) set
- Provides efficient direct access to the unspent transaction outputs
- Uses a domain specific compression algorithm that understands the
standard transaction scripts in order to significantly compress them
- Removes reliance on the transaction index and paves the way toward
eventually enabling block pruning
- Modify the New function to accept a Config struct instead of
inidividual parameters
- Replace the old TxStore type with a new UtxoViewpoint type that makes
use of the new pruned utxo set
- Convert code to treat the new UtxoViewpoint as a rolling view that is
used between connects and disconnects to improve efficiency
- Make best chain state always set when the chain instance is created
- Remove now unnecessary logic for dealing with unset best state
- Make all exported functions concurrent safe
- Currently using a single chain state lock as it provides a straight
forward and easy to review path forward however this can be improved
with more fine grained locking
- Optimize various cases where full blocks were being loaded when only
the header is needed to help reduce the I/O load
- Add the ability for callers to get a snapshot of the current best
chain stats in a concurrent safe fashion
- Does not block callers while new blocks are being processed
- Make error messages that reference transaction outputs consistently
use <transaction hash>:<output index>
- Introduce a new AssertError type an convert internal consistency
checks to use it
- Update tests and examples to reflect the changes
- Add a full suite of tests to ensure correct functionality of the new
code
The following is an overview of the btcd changes:
- Update to use the new database and chain interfaces
- Temporarily remove all code related to the transaction index
- Temporarily remove all code related to the address index
- Convert all code that uses transaction stores to use the new utxo
view
- Rework several calls that required the block manager for safe
concurrency to use the chain package directly now that it is
concurrent safe
- Change all calls to obtain the best hash to use the new best state
snapshot capability from the chain package
- Remove workaround for limits on fetching height ranges since the new
database interface no longer imposes them
- Correct the gettxout RPC handler to return the best chain hash as
opposed the hash the txout was found in
- Optimize various RPC handlers:
- Change several of the RPC handlers to use the new chain snapshot
capability to avoid needlessly loading data
- Update several handlers to use new functionality to avoid accessing
the block manager so they are able to return the data without
blocking when the server is busy processing blocks
- Update non-verbose getblock to avoid deserialization and
serialization overhead
- Update getblockheader to request the block height directly from
chain and only load the header
- Update getdifficulty to use the new cached data from chain
- Update getmininginfo to use the new cached data from chain
- Update non-verbose getrawtransaction to avoid deserialization and
serialization overhead
- Update gettxout to use the new utxo store versus loading
full transactions using the transaction index
The following is an overview of the utility changes:
- Update addblock to use the new database and chain interfaces
- Update findcheckpoint to use the new database and chain interfaces
- Remove the dropafter utility which is no longer supported
NOTE: The transaction index and address index will be reimplemented in
another commit.
137 lines
4.2 KiB
Go
137 lines
4.2 KiB
Go
// Copyright (c) 2014 The btcsuite developers
|
|
// Copyright (c) 2015-2016 The Decred developers
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"github.com/decred/dcrd/blockchain"
|
|
"github.com/decred/dcrd/wire"
|
|
)
|
|
|
|
// RuleError identifies a rule violation. It is used to indicate that
|
|
// processing of a transaction failed due to one of the many validation
|
|
// rules. The caller can use type assertions to determine if a failure was
|
|
// specifically due to a rule violation and use the Err field to access the
|
|
// underlying error, which will be either a TxRuleError or a
|
|
// blockchain.RuleError.
|
|
type RuleError struct {
|
|
Err error
|
|
}
|
|
|
|
// Error satisfies the error interface and prints human-readable errors.
|
|
func (e RuleError) Error() string {
|
|
if e.Err == nil {
|
|
return "<nil>"
|
|
}
|
|
return e.Err.Error()
|
|
}
|
|
|
|
// TxRuleError identifies a rule violation. It is used to indicate that
|
|
// processing of a transaction failed due to one of the many validation
|
|
// rules. The caller can use type assertions to determine if a failure was
|
|
// specifically due to a rule violation and access the ErrorCode field to
|
|
// ascertain the specific reason for the rule violation.
|
|
type TxRuleError struct {
|
|
RejectCode wire.RejectCode // The code to send with reject messages
|
|
Description string // Human readable description of the issue
|
|
}
|
|
|
|
// Error satisfies the error interface and prints human-readable errors.
|
|
func (e TxRuleError) Error() string {
|
|
return e.Description
|
|
}
|
|
|
|
// txRuleError creates an underlying TxRuleError with the given a set of
|
|
// arguments and returns a RuleError that encapsulates it.
|
|
func txRuleError(c wire.RejectCode, desc string) RuleError {
|
|
return RuleError{
|
|
Err: TxRuleError{RejectCode: c, Description: desc},
|
|
}
|
|
}
|
|
|
|
// chainRuleError returns a RuleError that encapsulates the given
|
|
// blockchain.RuleError.
|
|
func chainRuleError(chainErr blockchain.RuleError) RuleError {
|
|
return RuleError{
|
|
Err: chainErr,
|
|
}
|
|
}
|
|
|
|
// extractRejectCode attempts to return a relevant reject code for a given error
|
|
// by examining the error for known types. It will return true if a code
|
|
// was successfully extracted.
|
|
func extractRejectCode(err error) (wire.RejectCode, bool) {
|
|
// Pull the underlying error out of a RuleError.
|
|
if rerr, ok := err.(RuleError); ok {
|
|
err = rerr.Err
|
|
}
|
|
|
|
switch err := err.(type) {
|
|
case blockchain.RuleError:
|
|
// Convert the chain error to a reject code.
|
|
var code wire.RejectCode
|
|
switch err.ErrorCode {
|
|
// Rejected due to duplicate.
|
|
case blockchain.ErrDuplicateBlock:
|
|
fallthrough
|
|
case blockchain.ErrDoubleSpend:
|
|
code = wire.RejectDuplicate
|
|
|
|
// Rejected due to obsolete version.
|
|
case blockchain.ErrBlockVersionTooOld:
|
|
code = wire.RejectObsolete
|
|
|
|
// Rejected due to checkpoint.
|
|
case blockchain.ErrCheckpointTimeTooOld:
|
|
fallthrough
|
|
case blockchain.ErrDifficultyTooLow:
|
|
fallthrough
|
|
case blockchain.ErrBadCheckpoint:
|
|
fallthrough
|
|
case blockchain.ErrForkTooOld:
|
|
code = wire.RejectCheckpoint
|
|
|
|
// Everything else is due to the block or transaction being invalid.
|
|
default:
|
|
code = wire.RejectInvalid
|
|
}
|
|
|
|
return code, true
|
|
|
|
case TxRuleError:
|
|
return err.RejectCode, true
|
|
|
|
case nil:
|
|
return wire.RejectInvalid, false
|
|
}
|
|
|
|
return wire.RejectInvalid, false
|
|
}
|
|
|
|
// errToRejectErr examines the underlying type of the error and returns a reject
|
|
// code and string appropriate to be sent in a wire.MsgReject message.
|
|
func errToRejectErr(err error) (wire.RejectCode, string) {
|
|
// Return the reject code along with the error text if it can be
|
|
// extracted from the error.
|
|
rejectCode, found := extractRejectCode(err)
|
|
if found {
|
|
return rejectCode, err.Error()
|
|
}
|
|
|
|
// Return a generic rejected string if there is no error. This really
|
|
// should not happen unless the code elsewhere is not setting an error
|
|
// as it should be, but it's best to be safe and simply return a generic
|
|
// string rather than allowing the following code that dereferences the
|
|
// err to panic.
|
|
if err == nil {
|
|
return wire.RejectInvalid, "rejected"
|
|
}
|
|
|
|
// When the underlying error is not one of the above cases, just return
|
|
// wire.RejectInvalid with a generic rejected string plus the error
|
|
// text.
|
|
return wire.RejectInvalid, "rejected: " + err.Error()
|
|
}
|