mirror of
https://github.com/FlipsideCrypto/dcrd.git
synced 2026-02-06 10:56:47 +00:00
This commit is the first stage of several that are planned to convert
the blockchain package into a concurrent safe package that will
ultimately allow support for multi-peer download and concurrent chain
processing. The goal is to update btcd proper after each step so it can
take advantage of the enhancements as they are developed.
In addition to the aforementioned benefit, this staged approach has been
chosen since it is absolutely critical to maintain consensus.
Separating the changes into several stages makes it easier for reviewers
to logically follow what is happening and therefore helps prevent
consensus bugs. Naturally there are significant automated tests to help
prevent consensus issues as well.
The main focus of this stage is to convert the blockchain package to use
the new database interface and implement the chain-related functionality
which it no longer handles. It also aims to improve efficiency in
various areas by making use of the new database and chain capabilities.
The following is an overview of the chain changes:
- Update to use the new database interface
- Add chain-related functionality that the old database used to handle
- Main chain structure and state
- Transaction spend tracking
- Implement a new pruned unspent transaction output (utxo) set
- Provides efficient direct access to the unspent transaction outputs
- Uses a domain specific compression algorithm that understands the
standard transaction scripts in order to significantly compress them
- Removes reliance on the transaction index and paves the way toward
eventually enabling block pruning
- Modify the New function to accept a Config struct instead of
inidividual parameters
- Replace the old TxStore type with a new UtxoViewpoint type that makes
use of the new pruned utxo set
- Convert code to treat the new UtxoViewpoint as a rolling view that is
used between connects and disconnects to improve efficiency
- Make best chain state always set when the chain instance is created
- Remove now unnecessary logic for dealing with unset best state
- Make all exported functions concurrent safe
- Currently using a single chain state lock as it provides a straight
forward and easy to review path forward however this can be improved
with more fine grained locking
- Optimize various cases where full blocks were being loaded when only
the header is needed to help reduce the I/O load
- Add the ability for callers to get a snapshot of the current best
chain stats in a concurrent safe fashion
- Does not block callers while new blocks are being processed
- Make error messages that reference transaction outputs consistently
use <transaction hash>:<output index>
- Introduce a new AssertError type an convert internal consistency
checks to use it
- Update tests and examples to reflect the changes
- Add a full suite of tests to ensure correct functionality of the new
code
The following is an overview of the btcd changes:
- Update to use the new database and chain interfaces
- Temporarily remove all code related to the transaction index
- Temporarily remove all code related to the address index
- Convert all code that uses transaction stores to use the new utxo
view
- Rework several calls that required the block manager for safe
concurrency to use the chain package directly now that it is
concurrent safe
- Change all calls to obtain the best hash to use the new best state
snapshot capability from the chain package
- Remove workaround for limits on fetching height ranges since the new
database interface no longer imposes them
- Correct the gettxout RPC handler to return the best chain hash as
opposed the hash the txout was found in
- Optimize various RPC handlers:
- Change several of the RPC handlers to use the new chain snapshot
capability to avoid needlessly loading data
- Update several handlers to use new functionality to avoid accessing
the block manager so they are able to return the data without
blocking when the server is busy processing blocks
- Update non-verbose getblock to avoid deserialization and
serialization overhead
- Update getblockheader to request the block height directly from
chain and only load the header
- Update getdifficulty to use the new cached data from chain
- Update getmininginfo to use the new cached data from chain
- Update non-verbose getrawtransaction to avoid deserialization and
serialization overhead
- Update gettxout to use the new utxo store versus loading
full transactions using the transaction index
The following is an overview of the utility changes:
- Update addblock to use the new database and chain interfaces
- Update findcheckpoint to use the new database and chain interfaces
- Remove the dropafter utility which is no longer supported
NOTE: The transaction index and address index will be reimplemented in
another commit.
152 lines
5.2 KiB
Go
152 lines
5.2 KiB
Go
// Copyright (c) 2014 The btcsuite developers
|
|
// Copyright (c) 2015-2016 The Decred developers
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package dcrjson
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
)
|
|
|
|
// RPCErrorCode represents an error code to be used as a part of an RPCError
|
|
// which is in turn used in a JSON-RPC Response object.
|
|
//
|
|
// A specific type is used to help ensure the wrong errors aren't used.
|
|
type RPCErrorCode int
|
|
|
|
// RPCError represents an error that is used as a part of a JSON-RPC Response
|
|
// object.
|
|
type RPCError struct {
|
|
Code RPCErrorCode `json:"code,omitempty"`
|
|
Message string `json:"message,omitempty"`
|
|
}
|
|
|
|
// Guarantee RPCError satisifies the builtin error interface.
|
|
var _, _ error = RPCError{}, (*RPCError)(nil)
|
|
|
|
// Error returns a string describing the RPC error. This satisifies the
|
|
// builtin error interface.
|
|
func (e RPCError) Error() string {
|
|
return fmt.Sprintf("%d: %s", e.Code, e.Message)
|
|
}
|
|
|
|
// NewRPCError constructs and returns a new JSON-RPC error that is suitable
|
|
// for use in a JSON-RPC Response object.
|
|
func NewRPCError(code RPCErrorCode, message string) *RPCError {
|
|
return &RPCError{
|
|
Code: code,
|
|
Message: message,
|
|
}
|
|
}
|
|
|
|
// IsValidIDType checks that the ID field (which can go in any of the JSON-RPC
|
|
// requests, responses, or notifications) is valid. JSON-RPC 1.0 allows any
|
|
// valid JSON type. JSON-RPC 2.0 (which bitcoind follows for some parts) only
|
|
// allows string, number, or null, so this function restricts the allowed types
|
|
// to that list. This function is only provided in case the caller is manually
|
|
// marshalling for some reason. The functions which accept an ID in this
|
|
// package already call this function to ensure the provided id is valid.
|
|
func IsValidIDType(id interface{}) bool {
|
|
switch id.(type) {
|
|
case int, int8, int16, int32, int64,
|
|
uint, uint8, uint16, uint32, uint64,
|
|
float32, float64,
|
|
string,
|
|
nil:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// Request is a type for raw JSON-RPC 1.0 requests. The Method field identifies
|
|
// the specific command type which in turns leads to different parameters.
|
|
// Callers typically will not use this directly since this package provides a
|
|
// statically typed command infrastructure which handles creation of these
|
|
// requests, however this struct it being exported in case the caller wants to
|
|
// construct raw requests for some reason.
|
|
type Request struct {
|
|
Jsonrpc string `json:"jsonrpc"`
|
|
Method string `json:"method"`
|
|
Params []json.RawMessage `json:"params"`
|
|
ID interface{} `json:"id"`
|
|
}
|
|
|
|
// NewRequest returns a new JSON-RPC 1.0 request object given the provided id,
|
|
// method, and parameters. The parameters are marshalled into a json.RawMessage
|
|
// for the Params field of the returned request object. This function is only
|
|
// provided in case the caller wants to construct raw requests for some reason.
|
|
//
|
|
// Typically callers will instead want to create a registered concrete command
|
|
// type with the NewCmd or New<Foo>Cmd functions and call the MarshalCmd
|
|
// function with that command to generate the marshalled JSON-RPC request.
|
|
func NewRequest(id interface{}, method string, params []interface{}) (*Request, error) {
|
|
if !IsValidIDType(id) {
|
|
str := fmt.Sprintf("the id of type '%T' is invalid", id)
|
|
return nil, makeError(ErrInvalidType, str)
|
|
}
|
|
|
|
rawParams := make([]json.RawMessage, 0, len(params))
|
|
for _, param := range params {
|
|
marshalledParam, err := json.Marshal(param)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rawMessage := json.RawMessage(marshalledParam)
|
|
rawParams = append(rawParams, rawMessage)
|
|
}
|
|
|
|
return &Request{
|
|
Jsonrpc: "1.0",
|
|
ID: id,
|
|
Method: method,
|
|
Params: rawParams,
|
|
}, nil
|
|
}
|
|
|
|
// Response is the general form of a JSON-RPC response. The type of the Result
|
|
// field varies from one command to the next, so it is implemented as an
|
|
// interface. The ID field has to be a pointer for Go to put a null in it when
|
|
// empty.
|
|
type Response struct {
|
|
Result json.RawMessage `json:"result"`
|
|
Error *RPCError `json:"error"`
|
|
ID *interface{} `json:"id"`
|
|
}
|
|
|
|
// NewResponse returns a new JSON-RPC response object given the provided id,
|
|
// marshalled result, and RPC error. This function is only provided in case the
|
|
// caller wants to construct raw responses for some reason.
|
|
//
|
|
// Typically callers will instead want to create the fully marshalled JSON-RPC
|
|
// response to send over the wire with the MarshalResponse function.
|
|
func NewResponse(id interface{}, marshalledResult []byte, rpcErr *RPCError) (*Response, error) {
|
|
if !IsValidIDType(id) {
|
|
str := fmt.Sprintf("the id of type '%T' is invalid", id)
|
|
return nil, makeError(ErrInvalidType, str)
|
|
}
|
|
|
|
pid := &id
|
|
return &Response{
|
|
Result: marshalledResult,
|
|
Error: rpcErr,
|
|
ID: pid,
|
|
}, nil
|
|
}
|
|
|
|
// MarshalResponse marshals the passed id, result, and RPCError to a JSON-RPC
|
|
// response byte slice that is suitable for transmission to a JSON-RPC client.
|
|
func MarshalResponse(id interface{}, result interface{}, rpcErr *RPCError) ([]byte, error) {
|
|
marshalledResult, err := json.Marshal(result)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
response, err := NewResponse(id, marshalledResult, rpcErr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return json.Marshal(&response)
|
|
}
|