From 40f2f080c6a84df0adb5a89bf81ed16c6d4608c0 Mon Sep 17 00:00:00 2001 From: Eric Laurello Date: Fri, 1 Nov 2024 11:19:49 -0400 Subject: [PATCH] descriptions, test names - PR feedback --- models/descriptions/amount_adj.md | 5 +++ models/descriptions/amount_unadj.md | 5 +++ models/descriptions/amount_usd.md | 5 +++ models/descriptions/symbol.md | 5 +++ .../tables/core__fact_transfers.md | 2 +- models/gold/defi/defi__ez_bridge_activity.yml | 40 ++++++++++--------- .../gold/defi/defi__fact_bridge_activity.yml | 10 ++--- .../bridge/silver__bridge_celer_transfers.yml | 3 ++ .../defi/bridge/silver__bridge_combined.sql | 2 - .../silver__bridge_layerzero_transfers.yml | 4 +- .../bridge/silver__bridge_mover_transfers.yml | 2 + ...ilver__bridge_layerzero_transfers_full.yml | 2 + ...ver__bridge_layerzero_transfers_recent.yml | 2 + 13 files changed, 60 insertions(+), 27 deletions(-) create mode 100644 models/descriptions/amount_adj.md create mode 100644 models/descriptions/amount_unadj.md create mode 100644 models/descriptions/amount_usd.md create mode 100644 models/descriptions/symbol.md diff --git a/models/descriptions/amount_adj.md b/models/descriptions/amount_adj.md new file mode 100644 index 0000000..95622bf --- /dev/null +++ b/models/descriptions/amount_adj.md @@ -0,0 +1,5 @@ +{% docs amount_adj %} + +The decimal adjusted amount of a token. + +{% enddocs %} diff --git a/models/descriptions/amount_unadj.md b/models/descriptions/amount_unadj.md new file mode 100644 index 0000000..40eb2ab --- /dev/null +++ b/models/descriptions/amount_unadj.md @@ -0,0 +1,5 @@ +{% docs amount_unadj %} + +The non-decimal adjusted amount of a token. For example, if a token has 18 decimals, then the amount of 1 token is 10^18. + +{% enddocs %} diff --git a/models/descriptions/amount_usd.md b/models/descriptions/amount_usd.md new file mode 100644 index 0000000..6f32555 --- /dev/null +++ b/models/descriptions/amount_usd.md @@ -0,0 +1,5 @@ +{% docs amount_usd %} + +The US dollar equivalent of the amount of a token. + +{% enddocs %} diff --git a/models/descriptions/symbol.md b/models/descriptions/symbol.md new file mode 100644 index 0000000..0c16f42 --- /dev/null +++ b/models/descriptions/symbol.md @@ -0,0 +1,5 @@ +{% docs symbol %} + +The symbol of asset. + +{% enddocs %} \ No newline at end of file diff --git a/models/descriptions/tables/core__fact_transfers.md b/models/descriptions/tables/core__fact_transfers.md index f0b5a77..785cc7d 100644 --- a/models/descriptions/tables/core__fact_transfers.md +++ b/models/descriptions/tables/core__fact_transfers.md @@ -1,5 +1,5 @@ {% docs core__fact_transfers %} -This table contains Deposit and Withdraw events on the aptos blockchain. +This table contains Deposit and Withdraw events on the aptos blockchain. Note: transfers with a 0 amount are excluded. {% enddocs %} diff --git a/models/gold/defi/defi__ez_bridge_activity.yml b/models/gold/defi/defi__ez_bridge_activity.yml index e4d39bb..c2b5705 100644 --- a/models/gold/defi/defi__ez_bridge_activity.yml +++ b/models/gold/defi/defi__ez_bridge_activity.yml @@ -14,32 +14,32 @@ models: description: '{{ doc("block_number") }}' tests: - not_null: - Where: block_timestamp::Date > current_Date-3 - name: block_number_not_null + where: block_timestamp::Date > current_Date-3 + name: test_defi__block_number_not_null - name: BLOCK_TIMESTAMP description: '{{ doc("block_timestamp") }}' tests: - not_null: - Where: block_timestamp::Date > current_Date-3 - name: block_timestamp_not_null + where: block_timestamp::Date > current_Date-3 + name: test_defi__block_timestamp_not_null - name: TX_HASH description: '{{ doc("tx_hash") }}' tests: - not_null: - Where: block_timestamp::Date > current_Date-3 - name: tx_hash_not_null + where: block_timestamp::Date > current_Date-3 + name: test_defi__tx_hash_not_null - name: VERSION description: '{{ doc("version") }}' tests: - not_null: - Where: block_timestamp::Date > current_Date-3 - name: version_not_null + where: block_timestamp::Date > current_Date-3 + name: test_defi__version_not_null - name: BRIDGE_ADDRESS description: '{{ doc("bridge_address") }}' tests: - not_null: - Where: block_timestamp::Date > current_Date-3 - name: bridge_address_not_null + where: block_timestamp::Date > current_Date-3 + name: test_defi__bridge_address_not_null - name: PLATFORM description: '{{ doc("bridge_platform") }}' - name: EVENT_NAME @@ -50,22 +50,26 @@ models: description: '{{ doc("bridge_sender") }}' - name: RECEIVER description: '{{ doc("bridge_receiver") }}' - - name: SOURCE_CHAIN_NAME + - name: SOURCE_CHAIN description: '{{ doc("source_chain") }}' - - name: SOURCE_CHAIN_ID - description: '{{ doc("source_chain_id") }}' - - name: DESTINATION_CHAIN_NAME + - name: DESTINATION_CHAIN description: '{{ doc("destination_chain") }}' tests: - not_null: where: not (block_timestamp::date = '2024-10-21' and tx_hash in ('0x49238b4dd1781d0a9afd48faddeba919a0a72775e2b490b4996c50dc78ba525e', '0x206842922be81e92617e5119bf4be6ed660caa246c6bd5f18f87d3b6e0d25fcc', '0x8fd8ef755ba07ac320fce358d707d3433066e5f82df509ad76bd9b6d466bc5a6', '0x509d8cb84f175ecafef0ce8951dc77cc11ae997068d444285b97e3d31eb73338')) - name: destination_chain_name_not_null - - name: DESTINATION_CHAIN_ID - description: '{{ doc("destination_chain_id") }}' + name: test_defi__destination_chain_name_not_null - name: TOKEN_ADDRESS description: '{{ doc("bridge_token_address") }}' + - name: SYMBOL + description: '{{ doc("symbol") }}' - name: AMOUNT_UNADJ - description: '{{ doc("amount") }}' + description: '{{ doc("amount_unadj") }}' + - name: AMOUNT + description: '{{ doc("amount_adj") }}' + - name: AMOUNT_USD + description: '{{ doc("amount_usd") }}' + - name: EVENT_INDEX + description: '{{ doc("event_index") }}' - name: FACT_BRIDGE_ACTIVITY_ID description: '{{ doc("pk") }}' - name: INSERTED_TIMESTAMP diff --git a/models/gold/defi/defi__fact_bridge_activity.yml b/models/gold/defi/defi__fact_bridge_activity.yml index f8b2a0a..2953089 100644 --- a/models/gold/defi/defi__fact_bridge_activity.yml +++ b/models/gold/defi/defi__fact_bridge_activity.yml @@ -17,25 +17,25 @@ models: tests: - not_null: where: block_timestamp::Date > current_Date-3 - name: block_timestamp_not_null_test + name: test_defi__block_timestamp_not_null_test - name: TX_HASH description: '{{ doc("tx_hash") }}' tests: - not_null: where: block_timestamp::Date > current_Date-3 - name: tx_hash_not_null_test + name: test_defi__tx_hash_not_null_test - name: VERSION description: '{{ doc("version") }}' tests: - not_null: where: block_timestamp::Date > current_Date-3 - name: version_not_null_test + name: test_defi__version_not_null_test - name: BRIDGE_ADDRESS description: '{{ doc("bridge_address") }}' tests: - not_null: where: block_timestamp::Date > current_Date-3 - name: bridge_address_not_null_test + name: test_defi__bridge_address_not_null_test - name: PLATFORM description: '{{ doc("bridge_platform") }}' - name: EVENT_NAME @@ -55,7 +55,7 @@ models: tests: - not_null: where: not (block_timestamp::date ='2024-10-21' and tx_hash in ('0x49238b4dd1781d0a9afd48faddeba919a0a72775e2b490b4996c50dc78ba525e','0x206842922be81e92617e5119bf4be6ed660caa246c6bd5f18f87d3b6e0d25fcc','0x8fd8ef755ba07ac320fce358d707d3433066e5f82df509ad76bd9b6d466bc5a6','0x509d8cb84f175ecafef0ce8951dc77cc11ae997068d444285b97e3d31eb73338')) - name: destination_chain_name_not_null_test + name: test_defi__destination_chain_name_not_null_test - name: DESTINATION_CHAIN_ID description: '{{ doc("destination_chain_id") }}' - name: TOKEN_ADDRESS diff --git a/models/silver/defi/bridge/silver__bridge_celer_transfers.yml b/models/silver/defi/bridge/silver__bridge_celer_transfers.yml index 76bd7ae..0bf0260 100644 --- a/models/silver/defi/bridge/silver__bridge_celer_transfers.yml +++ b/models/silver/defi/bridge/silver__bridge_celer_transfers.yml @@ -54,5 +54,8 @@ models: tests: - not_null - name: AMOUNT_UNADJ + tests: + - not_null + - name: EVENT_INDEX tests: - not_null \ No newline at end of file diff --git a/models/silver/defi/bridge/silver__bridge_combined.sql b/models/silver/defi/bridge/silver__bridge_combined.sql index ff87d7d..e9353eb 100644 --- a/models/silver/defi/bridge/silver__bridge_combined.sql +++ b/models/silver/defi/bridge/silver__bridge_combined.sql @@ -43,8 +43,6 @@ FROM {% if not loop.last %} -{% if is_incremental() %} -{% endif %} UNION ALL {% endif %} {% endfor %}) \ No newline at end of file diff --git a/models/silver/defi/bridge/silver__bridge_layerzero_transfers.yml b/models/silver/defi/bridge/silver__bridge_layerzero_transfers.yml index aa52002..15f157f 100644 --- a/models/silver/defi/bridge/silver__bridge_layerzero_transfers.yml +++ b/models/silver/defi/bridge/silver__bridge_layerzero_transfers.yml @@ -20,4 +20,6 @@ models: - name: DESTINATION_CHAIN_ID - name: DESTINATION_CHAIN_NAME - name: TOKEN_ADDRESS - - name: AMOUNT_UNADJ \ No newline at end of file + - name: AMOUNT_UNADJ + - name: EVENT_INDEX + \ No newline at end of file diff --git a/models/silver/defi/bridge/silver__bridge_mover_transfers.yml b/models/silver/defi/bridge/silver__bridge_mover_transfers.yml index d426fc6..8a256b0 100644 --- a/models/silver/defi/bridge/silver__bridge_mover_transfers.yml +++ b/models/silver/defi/bridge/silver__bridge_mover_transfers.yml @@ -55,4 +55,6 @@ models: - not_null - name: AMOUNT_UNADJ tests: + - not_null + - name: EVENT_INDEX - not_null \ No newline at end of file diff --git a/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_full.yml b/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_full.yml index e3af468..87592f3 100644 --- a/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_full.yml +++ b/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_full.yml @@ -49,4 +49,6 @@ models: - not_null - name: AMOUNT_UNADJ tests: + - not_null + - name: EVENT_INDEX - not_null \ No newline at end of file diff --git a/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_recent.yml b/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_recent.yml index 8d31f8e..255e060 100644 --- a/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_recent.yml +++ b/models/silver/defi/bridge/tests/silver__bridge_layerzero_transfers_recent.yml @@ -52,4 +52,6 @@ models: - not_null - name: AMOUNT_UNADJ tests: + - not_null + - name: EVENT_INDEX - not_null \ No newline at end of file