From fdc141cf05d5c73480185a75b260019f91c33b77 Mon Sep 17 00:00:00 2001 From: Max Boguslavsky <521205+maxbogus@users.noreply.github.com> Date: Sat, 13 Jul 2019 00:51:23 +0300 Subject: [PATCH] updated script ext html webpack plugin to match interface of Plugin (#36835) * updated definition * corrected formatting * added test * reverted changes --- types/script-ext-html-webpack-plugin/index.d.ts | 4 +++- .../script-ext-html-webpack-plugin-tests.ts | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/types/script-ext-html-webpack-plugin/index.d.ts b/types/script-ext-html-webpack-plugin/index.d.ts index 636ac550e5..11371734d6 100644 --- a/types/script-ext-html-webpack-plugin/index.d.ts +++ b/types/script-ext-html-webpack-plugin/index.d.ts @@ -4,12 +4,14 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 -import { Plugin } from "webpack"; +import { Compiler, Plugin } from 'webpack'; export = ScriptExtHtmlWebpackPlugin; declare class ScriptExtHtmlWebpackPlugin extends Plugin { constructor(options?: ScriptExtHtmlWebpackPlugin.Options); + + apply(compiler: Compiler): void; } type ScriptMatchingPatternBase = diff --git a/types/script-ext-html-webpack-plugin/script-ext-html-webpack-plugin-tests.ts b/types/script-ext-html-webpack-plugin/script-ext-html-webpack-plugin-tests.ts index 84c42b2ae9..34b8074e01 100644 --- a/types/script-ext-html-webpack-plugin/script-ext-html-webpack-plugin-tests.ts +++ b/types/script-ext-html-webpack-plugin/script-ext-html-webpack-plugin-tests.ts @@ -1,8 +1,11 @@ import ScriptExtHtmlWebpackPlugin = require("script-ext-html-webpack-plugin"); +import webpack = require("webpack"); new ScriptExtHtmlWebpackPlugin(); new ScriptExtHtmlWebpackPlugin({}); +new ScriptExtHtmlWebpackPlugin().apply(new webpack.Compiler()); + new ScriptExtHtmlWebpackPlugin({ inline: "string", sync: "string",