🤖 Merge PR #45842 [underscore] Fix findIndex and findLastIndex signatures by @ProdigySim

This commit is contained in:
Michael Busby 2020-07-02 15:01:34 -05:00 committed by GitHub
parent ddf78235b0
commit f41b0557a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 4 deletions

View File

@ -4607,12 +4607,12 @@ declare module _ {
/**
* @see _.findIndex
**/
findIndex<T>(array: _.List<T>, predicate: _.ListIterator<T, boolean> | {}, context?: any): number;
findIndex(predicate: _.ListIterator<T, boolean> | {}, context?: any): number;
/**
* @see _.findLastIndex
**/
findLastIndex<T>(array: _.List<T>, predicate: _.ListIterator<T, boolean> | {}, context?: any): number;
findLastIndex(predicate: _.ListIterator<T, boolean> | {}, context?: any): number;
/**
* Wrapped type `any[]`.
@ -5568,12 +5568,12 @@ declare module _ {
/**
* @see _.findIndex
**/
findIndex<T>(predicate: _.ListIterator<T, boolean> | {}, context?: any): _ChainSingle<number>;
findIndex(predicate: _.ListIterator<T, boolean> | {}, context?: any): _ChainSingle<number>;
/**
* @see _.findLastIndex
**/
findLastIndex<T>(predicate: _.ListIterator<T, boolean> | {}, context?: any): _ChainSingle<number>;
findLastIndex(predicate: _.ListIterator<T, boolean> | {}, context?: any): _ChainSingle<number>;
/**
* Wrapped type `any[]`.

View File

@ -745,6 +745,19 @@ declare const extractChainTypes: ChainTypeExtractor;
extractChainTypes(_.chain(simpleString).chunk(length)); // $ExpectType ChainType<string[][], string[]>
}
// findIndex and findLastIndex
{
_([1, 2, 3, 1, 2, 3]).findIndex(num => num % 2 === 0); // $ExpectType number
_([{a: 'a'}, {a: 'b'}]).findIndex({a: 'b'}); // $ExpectType number
_.chain([1, 2, 3, 1, 2, 3]).findIndex(num => num % 2 === 0).value(); // $ExpectType number
_.chain([{a: 'a'}, {a: 'b'}]).findIndex({a: 'b'}).value(); // $ExpectType number
_([1, 2, 3, 1, 2, 3]).findLastIndex(num => num % 2 === 0); // $ExpectType number
_([{a: 'a'}, {a: 'b'}]).findLastIndex({ a: 'b' }); // $ExpectType number
_.chain([1, 2, 3, 1, 2, 3]).findLastIndex(num => num % 2 === 0).value(); // $ExpectType number
_.chain([{a: 'a'}, {a: 'b'}]).findLastIndex({ a: 'b' }).value(); // $ExpectType number
}
// OOP Style
// underscore