🤖 Merge PR #45123 Adds readme to Recurly.js by @dbrudner

* Adds readme to Recurly.js

* Fixes tests in recurly.js
This commit is contained in:
Dave Brudner 2020-05-29 18:50:27 -05:00 committed by GitHub
parent 0d8a27fbbd
commit ee6d7b2d47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions

View File

@ -0,0 +1,11 @@
# Contribution
## Pull Requests
In order to make sure the types for Recurly.js are kept up to date when new versions are released, the base types are contained in the [Recurly.js repository](https://github.com/recurly/recurly-js/tree/master/types).
To make a contribution and update the types for Recurly.js, open a pull request to update the types on Recurly.js. After it gets merged, an automated process will open a pull request with your new changes to DefinitelyTyped when the next version of Recurly.js is released.
## Issues
Similarly, if you encounter an issue with these types and would like to report it, [open an issue in the Recurly.js repository](https://github.com/recurly/recurly-js/issues).

View File

@ -8,8 +8,6 @@ import { RecurlyError } from '../error';
export interface PricingPromise<T, PricingMethods> extends Promise<T> {
/**
* Attaches callbacks for the resolution and/or rejection of the PricingPromise.
* @param onfulfilled The callback to execute when the PricingPromise is resolved.
* @param onrejected The callback to execute when the PricingPromise is rejected.
* @returns A PricingPromise for the completion of which ever callback is executed.
*/
then<TResult1 = T, TResult2 = never>(
@ -19,7 +17,6 @@ export interface PricingPromise<T, PricingMethods> extends Promise<T> {
/**
* Attaches a callback for only the rejection of the PricingPromise.
* @param onrejected The callback to execute when the PricingPromise is rejected.
* @returns A PricingPromise for the completion of the callback.
*/
catch<TResult = never>(
@ -30,8 +27,6 @@ export interface PricingPromise<T, PricingMethods> extends Promise<T> {
/**
* Attaches callbacks for the resolution and/or rejection of the PricingPromise, without returning a new promise.
* @param onfulfilled The callback to execute when the PricingPromise is resolved.
* @param onrejected The callback to execute when the PricingPromise is rejected.
*/
done(onfulfilled?: (value: T) => any, onrejected?: (reason: any) => any): T;
}