From fee7e62da8fe71e60db027e1e52d480641789b24 Mon Sep 17 00:00:00 2001 From: Jonathan Lui Date: Tue, 30 Oct 2018 16:23:06 -0700 Subject: [PATCH 1/2] add duplexify.obj(), cork() and uncork() to duplexify --- types/duplexify/duplexify-tests.ts | 8 ++++++++ types/duplexify/index.d.ts | 6 +++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/types/duplexify/duplexify-tests.ts b/types/duplexify/duplexify-tests.ts index 11d33d7303..aeed21e8dc 100644 --- a/types/duplexify/duplexify-tests.ts +++ b/types/duplexify/duplexify-tests.ts @@ -8,9 +8,17 @@ duplexify(writable, readable); duplexify(writable); duplexify(undefined, readable); +duplexify.obj(); +duplexify.obj(writable); +duplexify.obj(writable, readable); +duplexify.obj(writable, readable, {}); + const d: duplexify.Duplexify = duplexify(); d.setReadable(readable); d.setReadable(); // $ExpectError d.setWritable(writable); d.setWritable(); // $ExpectError +d.cork(); +d.uncork(); + const f: Duplex = d; diff --git a/types/duplexify/index.d.ts b/types/duplexify/index.d.ts index 791a000f8b..217de65bb0 100644 --- a/types/duplexify/index.d.ts +++ b/types/duplexify/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for duplexify 3.5 +// Type definitions for duplexify 3.6 // Project: https://github.com/mafintosh/duplexify // Definitions by: Sami Kukkonen // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -11,10 +11,14 @@ export = duplexify; interface DuplexifyConstructor { (writable?: stream.Writable, readable?: stream.Readable, streamOptions?: stream.DuplexOptions): duplexify.Duplexify; new (writable?: stream.Writable, readable?: stream.Readable, streamOptions?: stream.DuplexOptions): duplexify.Duplexify; + + obj(writable?: stream.Writable, readable?: stream.Readable, streamOptions?: stream.DuplexOptions): duplexify.Duplexify; } declare var duplexify: DuplexifyConstructor; declare namespace duplexify { interface Duplexify extends stream.Duplex { + cork(): void; + uncork(): void; setWritable(writable: stream.Writable): void; setReadable(readable: stream.Readable): void; } From c2b4cb1119dd172719c14028d747b7e57dc70d19 Mon Sep 17 00:00:00 2001 From: Jonathan Lui Date: Tue, 30 Oct 2018 16:26:12 -0700 Subject: [PATCH 2/2] add myself to contributor --- types/duplexify/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/duplexify/index.d.ts b/types/duplexify/index.d.ts index 217de65bb0..7df693e93b 100644 --- a/types/duplexify/index.d.ts +++ b/types/duplexify/index.d.ts @@ -1,6 +1,7 @@ // Type definitions for duplexify 3.6 // Project: https://github.com/mafintosh/duplexify // Definitions by: Sami Kukkonen +// Jonathan Lui // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped ///