From dfd742bfd246909063bd468ed24d36f9375c140b Mon Sep 17 00:00:00 2001
From: Erik Krogh Kristensen <erik@webbies.dk>
Date: Fri, 8 Feb 2019 13:18:40 +0100
Subject: [PATCH] js-cookie: last review fixes #32830

---
 types/js-cookie/index.d.ts         | 4 ++--
 types/js-cookie/js-cookie-tests.ts | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/types/js-cookie/index.d.ts b/types/js-cookie/index.d.ts
index 9f05f25016..7b90b4ecd5 100644
--- a/types/js-cookie/index.d.ts
+++ b/types/js-cookie/index.d.ts
@@ -79,7 +79,7 @@ declare namespace Cookies {
          * or SDK. Note: The noConflict method is not necessary when using
          * AMD or CommonJS, thus it is not exposed in those environments.
          */
-        noConflict?(): CookiesStatic;
+        noConflict?(): CookiesStatic<T>;
 
         /**
          * Create a new instance of the api that overrides the default
@@ -88,7 +88,7 @@ declare namespace Cookies {
          * will run the converter first for each cookie. The returned
          * string will be used as the cookie value.
          */
-        withConverter(converter: CookieReadConverter | { write: CookieWriteConverter<T>; read: CookieReadConverter; }): CookiesStatic;
+        withConverter<TConv extends object>(converter: CookieReadConverter | { write: CookieWriteConverter<TConv>; read: CookieReadConverter; }): CookiesStatic<TConv>;
     }
 
     type CookieWriteConverter<T extends object> = (value: string | T, name: string) => string;
diff --git a/types/js-cookie/js-cookie-tests.ts b/types/js-cookie/js-cookie-tests.ts
index 26bc055a90..df30d90975 100644
--- a/types/js-cookie/js-cookie-tests.ts
+++ b/types/js-cookie/js-cookie-tests.ts
@@ -40,7 +40,7 @@ cookies.get('escaped');
 Cookies.defaults.path = '';
 delete Cookies.defaults.path;
 
-const PHPCookies = Cookies.withConverter({
+const PHPCookies = Cookies.withConverter<object>({
     write(value) {
         value; // $ExpectType string | object
         return encodeURIComponent(value as string)