🤖 Merge PR #45742 fix(glider-js): add eventPropagate option by @peterblazejewicz

* fix(glider-js): add `eventPropagate` option

- missing `eventPropagate` option:
e0743bc3fc/README.md (L90)
This specific option is missin public facing documentation, see:
NickPiscitelli/Glider.js#111

/cc @martin-badin

Thanks!

* [pr] remove `propagateEvent` property as per review request

/cc @martin-badin
This commit is contained in:
Piotr Błażejewicz (Peter Blazejewicz) 2020-07-08 23:11:54 +02:00 committed by GitHub
parent bb2735dd73
commit b5b627cf71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions

View File

@ -7,6 +7,7 @@ const options: Glider.Options = {
prev: '.glider-prev',
next: document.querySelector('.glider-next'),
},
eventPropagate: true,
};
// Options.dots

View File

@ -121,12 +121,6 @@ declare namespace Glider {
*/
itemWidth?: number;
/**
* Whether or not Glider.js events should bubble (useful for binding
* events to all carousels)
*/
propagateEvent?: boolean;
/**
* If true, Glider.js will lock to the nearest slide on resizing of
* the window
@ -162,6 +156,12 @@ declare namespace Glider {
*/
scrollPropagate?: boolean;
/**
* Whether or not the event bubbles up from the container
* @default true
*/
eventPropagate?: boolean;
/**
* Whether or not Glider.js should skip wrapping its children with a
* 'glider-track' <div>.