From aff20085570a404b20ad36f33d2df73b3ce0753a Mon Sep 17 00:00:00 2001 From: Andrea Francesco Speziale Date: Tue, 26 May 2020 11:56:35 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#45057=20[node-pdft?= =?UTF-8?q?k]=20fix:=20input=20function=20accepts=20also=20a=20Buffer=20by?= =?UTF-8?q?=20@andreafspeziale?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- types/node-pdftk/index.d.ts | 2 +- types/node-pdftk/node-pdftk-tests.ts | 23 ++++++++++++++++------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/types/node-pdftk/index.d.ts b/types/node-pdftk/index.d.ts index 16625a0d82..f02a426b43 100644 --- a/types/node-pdftk/index.d.ts +++ b/types/node-pdftk/index.d.ts @@ -255,5 +255,5 @@ export interface ConfigureOptions { tempDir: string; } -export function input(file: string): PDFTK; +export function input(file: string | Buffer): PDFTK; export function configure(opts: ConfigureOptions): void; diff --git a/types/node-pdftk/node-pdftk-tests.ts b/types/node-pdftk/node-pdftk-tests.ts index 52738d5101..02dd472636 100644 --- a/types/node-pdftk/node-pdftk-tests.ts +++ b/types/node-pdftk/node-pdftk-tests.ts @@ -7,13 +7,22 @@ PDFTK.configure({ tempDir: './pdftk', }); -const pdftk = PDFTK.input('file'); // $ExpectType PDFTK +[ + { + input: 'string', + }, + { + input: Buffer.from('buffer'), + }, +].forEach(scenario => { + const pdftk = PDFTK.input(scenario.input); // $ExpectType PDFTK -pdftk.allow(['FillIn']).attachFiles(['./file1.pdf', './file2.pdf']); // $ExpectType PDFTK + pdftk.allow(['FillIn']).attachFiles(['./file1.pdf', './file2.pdf']); // $ExpectType PDFTK -pdftk.allow(['FillIn']).compress().output('./fileoutput.pdf'); // $ExpectType Promise -pdftk.allow(['FillIn']).compress().output('./fileoutput.pdf', './destination/folder'); // $ExpectType Promise -pdftk.allow(['FillIn']).compress().output(); // $ExpectType Promise + pdftk.allow(['FillIn']).compress().output('./fileoutput.pdf'); // $ExpectType Promise + pdftk.allow(['FillIn']).compress().output('./fileoutput.pdf', './destination/folder'); // $ExpectType Promise + pdftk.allow(['FillIn']).compress().output(); // $ExpectType Promise -PDFTK.input('file').flatten().ignoreWarnings().inputPw('password').burst('page_%02d.pdf'); // $ExpectType Promise -PDFTK.input('file').flatten().ignoreWarnings().inputPw('password').burst(); // $ExpectType Promise + PDFTK.input(scenario.input).flatten().ignoreWarnings().inputPw('password').burst('page_%02d.pdf'); // $ExpectType Promise + PDFTK.input(scenario.input).flatten().ignoreWarnings().inputPw('password').burst(); // $ExpectType Promise +});