From 987ef5f9e06983f72b63eaf16cceb05711ec0c69 Mon Sep 17 00:00:00 2001 From: Jason Yu Date: Mon, 4 May 2020 18:39:55 +0100 Subject: [PATCH] fix(update-dom-mediacapture-record): more specific addEventListener typing (#44237) --- .../dom-mediacapture-record-tests.ts | 6 ++++++ types/dom-mediacapture-record/index.d.ts | 2 ++ 2 files changed, 8 insertions(+) diff --git a/types/dom-mediacapture-record/dom-mediacapture-record-tests.ts b/types/dom-mediacapture-record/dom-mediacapture-record-tests.ts index 92ed2158a4..0840239e55 100644 --- a/types/dom-mediacapture-record/dom-mediacapture-record-tests.ts +++ b/types/dom-mediacapture-record/dom-mediacapture-record-tests.ts @@ -58,3 +58,9 @@ recorder.onpause = null; recorder.onresume = null; recorder.onstart = null; recorder.onstop = null; + +recorder.addEventListener('dataavailable', (e: BlobEvent) => {}); +recorder.addEventListener('error', (e: MediaRecorderErrorEvent) => {}); +recorder.addEventListener('pause', onEvent); +recorder.addEventListener('resume', onEvent); +recorder.addEventListener('dataavailable', onEvent); diff --git a/types/dom-mediacapture-record/index.d.ts b/types/dom-mediacapture-record/index.d.ts index 60a1f2fd88..0c61691d6e 100644 --- a/types/dom-mediacapture-record/index.d.ts +++ b/types/dom-mediacapture-record/index.d.ts @@ -58,7 +58,9 @@ declare class MediaRecorder extends EventTarget { constructor(stream: MediaStream, options?: MediaRecorderOptions); + addEventListener(type: K, listener: (this: MediaRecorder, ev: MediaRecorderEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void; addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void; + removeEventListener(type: K, listener: (this: MediaRecorder, ev: MediaRecorderEventMap[K]) => any, options?: boolean | EventListenerOptions): void; removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void; start(timeslice?: number): void;