🤖 Merge PR #44439 [detect-port]: add PortConfig type for first argument from default function by @ivandevp

* Add portconfig type for detect port first argument

* Update detect-port version

* Fix version format

* Remove autogenerated bin
This commit is contained in:
Ivan Medina 2020-05-03 08:38:50 -05:00 committed by GitHub
parent 0d04fc9671
commit 8bb6f0dc90
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 10 deletions

View File

@ -1,12 +1,12 @@
import * as detect from "detect-port";
import * as detect from 'detect-port';
const port = 8000;
const hostname = 'localhost';
/**
* callback usage
*/
detect(port, (err: Error, _port: number) => {
});
detect(port, (err: Error, _port: number) => {});
function* yieldSyntax() {
const _port: number = yield detect(port);
@ -16,7 +16,14 @@ function* yieldSyntax() {
* use as a promise
*/
detect(port)
.then((_port: number) => {
})
.catch(err => {
});
.then((_port: number) => {})
.catch(err => {});
/**
* port config usage
*/
detect({ port, hostname, callback: (err: Error, _port: number) => {} });
detect({ port, hostname })
.then((_port: number) => {})
.catch(err => {});

View File

@ -1,11 +1,20 @@
// Type definitions for detect-port 1.1
// Type definitions for detect-port 1.3
// Project: https://github.com/node-modules/detect-port
// Definitions by: François Nguyen <https://github.com/lith-light-g>
// Ivan Medina <https://github.com/ivandevp>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
type DetectPortCallback = (err: Error, _port: number) => void;
interface PortConfig {
port: number;
hostname?: string;
callback?: DetectPortCallback;
}
interface DetectPort {
(port: number, callback: (err: Error, _port: number) => void): void;
(port: number): Promise<number>;
(port: number | PortConfig, callback: DetectPortCallback): void;
(port: number | PortConfig): Promise<number>;
}
declare const detectPort: DetectPort;
export = detectPort;