From 7e4f7be66a19388b584cdc1dd0700be4833e478b Mon Sep 17 00:00:00 2001 From: Jace McPherson Date: Tue, 11 Jun 2019 17:39:07 -1000 Subject: [PATCH] Fixes optional/missing parameters for Google Tasks API. (#36012) "parent" is a required field on CreateTaskRequests (see the docs, for example the Quickstart guide at https://github.com/googleapis/nodejs-tasks) Not all of the properties on AppEngineHttpRequest are required, also observable from the quickstart like mentioned above. --- types/google-cloud__tasks/index.d.ts | 7 ++++--- types/google-cloud__tasks/ts3.1/index.d.ts | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/types/google-cloud__tasks/index.d.ts b/types/google-cloud__tasks/index.d.ts index c3347c8ea4..d673e89747 100644 --- a/types/google-cloud__tasks/index.d.ts +++ b/types/google-cloud__tasks/index.d.ts @@ -27,9 +27,9 @@ export interface AppEngineHttpQueue { } export interface AppEngineHttpRequest { - appEngineRouting: AppEngineRouting; + appEngineRouting?: AppEngineRouting; body: string; - headers: { + headers?: { [key: string]: string; }; httpMethod: string; @@ -57,7 +57,8 @@ export interface Binding { } export interface CreateTaskRequest { - responseView: View; + responseView?: View; + parent: string; task: Partial; } diff --git a/types/google-cloud__tasks/ts3.1/index.d.ts b/types/google-cloud__tasks/ts3.1/index.d.ts index 6b09fdd06d..59aee4bbf1 100644 --- a/types/google-cloud__tasks/ts3.1/index.d.ts +++ b/types/google-cloud__tasks/ts3.1/index.d.ts @@ -22,9 +22,9 @@ export interface AppEngineHttpQueue { } export interface AppEngineHttpRequest { - appEngineRouting: AppEngineRouting; + appEngineRouting?: AppEngineRouting; body: string; - headers: { + headers?: { [key: string]: string; }; httpMethod: string; @@ -52,7 +52,8 @@ export interface Binding { } export interface CreateTaskRequest { - responseView: View; + responseView?: View; + parent: string; task: Partial; }