From 7aae63bc297304b8d7708d87723c3f2cc71bbc5e Mon Sep 17 00:00:00 2001
From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Date: Wed, 16 Sep 2020 16:20:41 -0700
Subject: [PATCH] Fix bugs discovered by TS 4.1 (#47683)

1. TS 4.1 no longer has a built-in type named 'Position'.
2. TS 4.1 intentionally sets the global `name: void` to make it less
usable.

This flushed out a few bugs.
---
 types/better-scroll/index.d.ts                                 | 2 +-
 types/react-cytoscapejs/index.d.ts                             | 3 +--
 .../react-shadow-dom-retarget-events-tests.tsx                 | 1 +
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/types/better-scroll/index.d.ts b/types/better-scroll/index.d.ts
index 986d26afa5..141dde2b74 100644
--- a/types/better-scroll/index.d.ts
+++ b/types/better-scroll/index.d.ts
@@ -256,7 +256,7 @@ declare class BScroll {
             'scroll' |
             'scrollEnd' |
             'touchEnd',
-        fn: (pos: Position) => any
+        fn: (pos: BScroll.Position) => any
     ): void;
 
     off(
diff --git a/types/react-cytoscapejs/index.d.ts b/types/react-cytoscapejs/index.d.ts
index 2a84251ac7..aca2192236 100644
--- a/types/react-cytoscapejs/index.d.ts
+++ b/types/react-cytoscapejs/index.d.ts
@@ -2,7 +2,6 @@
 // Project: https://github.com/plotly/react-cytoscapejs
 // Definitions by:  Emmanuel COunasse <https://github.com/manuc66/>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// TypeScript Version: 2.8
 
 import cytoscape = require('cytoscape');
 import { Component, CSSProperties } from 'react';
@@ -16,7 +15,7 @@ interface CytoscapeComponentProps {
     stylesheet?: cytoscape.Stylesheet | cytoscape.Stylesheet[] | string;
     className?: string;
     zoom?: number;
-    pan?: Position;
+    pan?: cytoscape.Position;
     minZoom?: number;
     maxZoom?: number;
     zoomingEnabled?: boolean;
diff --git a/types/react-shadow-dom-retarget-events/react-shadow-dom-retarget-events-tests.tsx b/types/react-shadow-dom-retarget-events/react-shadow-dom-retarget-events-tests.tsx
index 27af7112ab..962e14c1f2 100644
--- a/types/react-shadow-dom-retarget-events/react-shadow-dom-retarget-events-tests.tsx
+++ b/types/react-shadow-dom-retarget-events/react-shadow-dom-retarget-events-tests.tsx
@@ -19,4 +19,5 @@ class MyCustomElement extends HTMLElement {
     }
 }
 
+const name = "name";
 customElements.define(name, MyCustomElement);