From 7619b2d6f57429772dcf095cc29f5075e8df9d6c Mon Sep 17 00:00:00 2001 From: Levi Bostian Date: Thu, 18 Jul 2019 19:45:07 -0500 Subject: [PATCH] Add typings for npm module uid2 (#36207) * Add typings for npm module uid2 * Add callback parameter to uid typing * Refactor uid2 typings to different style * Enable dt-header lint rule @types/uid2 * Fix tests --- types/uid2/index.d.ts | 9 +++++++++ types/uid2/tsconfig.json | 23 +++++++++++++++++++++++ types/uid2/tslint.json | 3 +++ types/uid2/uid2-tests.ts | 8 ++++++++ 4 files changed, 43 insertions(+) create mode 100644 types/uid2/index.d.ts create mode 100644 types/uid2/tsconfig.json create mode 100644 types/uid2/tslint.json create mode 100644 types/uid2/uid2-tests.ts diff --git a/types/uid2/index.d.ts b/types/uid2/index.d.ts new file mode 100644 index 0000000000..b3000548f9 --- /dev/null +++ b/types/uid2/index.d.ts @@ -0,0 +1,9 @@ +// Type definitions for uid2 0.0 +// Project: https://github.com/coreh/uid2 +// Definitions by: Levi Bostian +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +declare function uid2(length: number): string; +declare function uid2(length: number, callback: (err: Error | null, result?: string) => void): void; + +export = uid2; diff --git a/types/uid2/tsconfig.json b/types/uid2/tsconfig.json new file mode 100644 index 0000000000..649f9320eb --- /dev/null +++ b/types/uid2/tsconfig.json @@ -0,0 +1,23 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "strictFunctionTypes": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "uid2-tests.ts" + ] +} \ No newline at end of file diff --git a/types/uid2/tslint.json b/types/uid2/tslint.json new file mode 100644 index 0000000000..e60c15844f --- /dev/null +++ b/types/uid2/tslint.json @@ -0,0 +1,3 @@ +{ + "extends": "dtslint/dt.json" +} \ No newline at end of file diff --git a/types/uid2/uid2-tests.ts b/types/uid2/uid2-tests.ts new file mode 100644 index 0000000000..1ab471acc8 --- /dev/null +++ b/types/uid2/uid2-tests.ts @@ -0,0 +1,8 @@ +import uid2 = require('uid2'); + +uid2(20); // $ExpectType string + +uid2(20, (error, result) => { + error; // $ExpectType Error | null + result; // $ExpectType string | undefined +});