From 69bc9ed3f0768d20672136561ebdfd1b12bf50f3 Mon Sep 17 00:00:00 2001
From: thmiyathmary <hayato1203_zero_giga@yahoo.co.jp>
Date: Fri, 13 Mar 2020 07:50:03 +0900
Subject: [PATCH] [ioredis] Add lpop for Cluster (#43005)

Co-authored-by: thmiyathmary <hayato1023_zero_giga@yahoo.co.jp>
---
 types/ioredis/index.d.ts       |  3 +++
 types/ioredis/ioredis-tests.ts | 12 ++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/types/ioredis/index.d.ts b/types/ioredis/index.d.ts
index 717cab4855..4d6828ffa2 100644
--- a/types/ioredis/index.d.ts
+++ b/types/ioredis/index.d.ts
@@ -1326,6 +1326,9 @@ declare namespace IORedis {
 
         rpushBuffer(key: string, ...values: Buffer[]): Promise<number>;
 
+        lpop(key: KeyType, callback: (err: Error, res: string) => void): void;
+        lpop(key: KeyType): Promise<string>;
+
         lpopBuffer(key: KeyType, callback: (err: Error, res: Buffer) => void): void;
         lpopBuffer(key: KeyType): Promise<Buffer>;
 
diff --git a/types/ioredis/ioredis-tests.ts b/types/ioredis/ioredis-tests.ts
index cd19f613c0..8a59f7c4ae 100644
--- a/types/ioredis/ioredis-tests.ts
+++ b/types/ioredis/ioredis-tests.ts
@@ -278,6 +278,18 @@ cluster.decr('key', (err, data) => {
     // [null, '100']
 });
 
+listData.forEach(value => {
+    cluster.rpush('bufferlist', Buffer.from(value));
+});
+
+listData.forEach(value => {
+    cluster.lpop('bufferlist', (err, data) => {
+        if (data !== value) {
+            console.log(data);
+        }
+    });
+});
+
 listData.forEach(value => {
     cluster.rpushBuffer('bufferlist', Buffer.from(value));
 });