From 262cd5c3fc12d424b3c5a409b986e7eeb3f8cd4d Mon Sep 17 00:00:00 2001 From: Slimfit Date: Sat, 11 Apr 2015 11:13:27 -0400 Subject: [PATCH 1/3] CircularInstance.addData was incorrect addData takes a single object of type CircularChartData, not an array. Also the index is optional. See addData example in the documentation http://www.chartjs.org/docs/#doughnut-pie-chart-prototype-methods --- chartjs/chart.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chartjs/chart.d.ts b/chartjs/chart.d.ts index a73ecc94e2..44d5718032 100644 --- a/chartjs/chart.d.ts +++ b/chartjs/chart.d.ts @@ -113,7 +113,7 @@ interface LinearInstance extends ChartInstance { interface CircularInstance extends ChartInstance { getSegmentsAtEvent: (event: Event) => {}[]; update: () => void; - addData: (valuesArray: CircularChartData[], index: number) => void; + addData: (valuesArray: CircularChartData, index?: number) => void; removeData: (index: number) => void; } From 8fa20fff1e3ef282f39a4148edeb3e3ffe0a70fd Mon Sep 17 00:00:00 2001 From: Slimfit Date: Sat, 11 Apr 2015 11:27:24 -0400 Subject: [PATCH 2/3] Updated test file CircularInstance to match new addData signature --- chartjs/chart-tests.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chartjs/chart-tests.ts b/chartjs/chart-tests.ts index 2374b6228a..d63a6b504c 100644 --- a/chartjs/chart-tests.ts +++ b/chartjs/chart-tests.ts @@ -301,12 +301,12 @@ var myPieChart = new Chart(ctx).Pie(pieData, { var myPieChartLegend: string = myPieChart.generateLegend(); var myPieChartImage: string = myPieChart.toBase64Image(); -myPieChart.addData([{ +myPieChart.addData({ value: 120, color: "#4D5360", highlight: "#616774", label: "Dark Grey" -}], 0); +}, 0); myPieChart.clear(); myPieChart.removeData(0); myPieChart.resize(); From 32aae2c650b465b14b263e1995bd5cd5c26ef895 Mon Sep 17 00:00:00 2001 From: Slimfit Date: Sat, 11 Apr 2015 11:36:06 -0400 Subject: [PATCH 3/3] Missed a couple addData() calls in the test file --- chartjs/chart-tests.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/chartjs/chart-tests.ts b/chartjs/chart-tests.ts index d63a6b504c..4bd8820c6c 100644 --- a/chartjs/chart-tests.ts +++ b/chartjs/chart-tests.ts @@ -252,12 +252,12 @@ var myPolarAreaChart = new Chart(ctx).PolarArea(polarAreaData, { var myPolarAreaChartLegend: string = myPolarAreaChart.generateLegend(); var myPolarAreaChartImage: string = myPolarAreaChart.toBase64Image(); -myPolarAreaChart.addData([{ +myPolarAreaChart.addData({ value: 120, color: "#4D5360", highlight: "#616774", label: "Dark Grey" -}], 0); +}, 0); myPolarAreaChart.clear(); myPolarAreaChart.removeData(0); myPolarAreaChart.resize(); @@ -329,12 +329,12 @@ var myDoughnutChart = new Chart(ctx).Doughnut(pieData, { var myDoughnutChartLegend: string = myDoughnutChart.generateLegend(); var myDoughnutChartImage: string = myDoughnutChart.toBase64Image(); -myPieChart.addData([{ +myPieChart.addData({ value: 120, color: "#4D5360", highlight: "#616774", label: "Dark Grey" -}], 0); +}, 0); myDoughnutChart.clear(); myDoughnutChart.removeData(0); myDoughnutChart.resize();