Apply suggestions from code review

Co-authored-by: Ethan Arrowood <ethan.arrowood@gmail.com>
This commit is contained in:
Orta Therox 2020-07-21 18:50:02 -04:00 committed by GitHub
parent 5cb8ffc307
commit 4703d29eb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions

View File

@ -49,7 +49,7 @@ export namespace History {
// Now that TypeScript's DT support is 3.0+, we can look into replacing this with `unknown`.
type UnknownFacade = {} | null | undefined;
/** @deprecated - UnknownFacade is more clear about what's going on */
/** @deprecated - Use `UnknownFacade` instead. It is a better classifier for the type */
type PoorMansUnknown = UnknownFacade
export type LocationState = UnknownFacade;

View File

@ -1141,6 +1141,6 @@ declare namespace NodeJS {
// Now that TypeScript's DT support is 3.0+, we can look into replacing this with `unknown`.
type UnknownFacade = {} | null | undefined;
/** @deprecated - UnknownFacade is more clear about what's going on */
/** @deprecated - Use `UnknownFacade` instead. It is a better classifier for the type */
type PoorMansUnknown = UnknownFacade
}

View File

@ -1180,6 +1180,6 @@ declare namespace NodeJS {
// Now that TypeScript's DT support is 3.0+, we can look into replacing this with `unknown`.
type UnknownFacade = {} | null | undefined;
/** @deprecated - UnknownFacade is more clear about what's going on */
/** @deprecated - Use `UnknownFacade` instead. It is a better classifier for the type */
type PoorMansUnknown = UnknownFacade
}

2
types/qs/index.d.ts vendored
View File

@ -61,7 +61,7 @@ declare namespace QueryString {
// When these types support TypeScript 3.0+, we can replace this with `unknown`.
type UnknownFacade = {} | null | undefined;
/** @deprecated - UnknownFacade is more clear about what's going on */
/** @deprecated - Use `UnknownFacade` instead. It is a better classifier for the type */
type PoorMansUnknown = UnknownFacade
function stringify(obj: any, options?: IStringifyOptions): string;