flip/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/FlipsideCrypto/DefinitelyTyped.git synced 2026-02-06 02:47:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Adds a danger rule for when you keep the username from the template (#45364)

Browse Source
This commit is contained in:
Orta 2020-06-08 15:29:10 -04:00 committed by GitHub
parent d8867550b6
commit 44af094af2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dangerfile.ts
View File

@ -58,6 +58,14 @@ if (danger.git.created_files.some(f => path.basename(f) === ".editorconfig")) {
fail("A nested .editorconfig file may not be added to a package on DefinitelyTyped. Please respect the root .editorconfig.", danger.git.created_files.find(f => path.basename(f) === ".editorconfig"), 1)
}
// Tell people that they've added @me to their lib and not themselves
const newDTSFiles = danger.git.created_files.filter(f => f.endsWith(".d.ts"))
newDTSFiles.forEach(dts => {
const file = fs.readFileSync(dts, "utf8")
if (file.includes("<https://github.com/me>")) {
fail("This line should have your github username in it, not /me", dts, 3)
}
})
for (const filename of danger.git.modified_files.concat(danger.git.created_files)) {
danger.git.diffForFile(filename).then(d => {