From 433cf7ea6fa7ad5d56fb5f7813d969e2874a3484 Mon Sep 17 00:00:00 2001 From: Christian Bewernitz Date: Tue, 7 Jul 2020 01:30:01 +0200 Subject: [PATCH] fix(@types/xmldom): Move `dom` from tsconfig to `index.d.ts` (#45752) By adding `/// ` to the type definition [as described in the handbook](https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-lib-) it's no longer required to add `"lib":[...,"dom"]` to the `tsconfig.json` I also added myself as a maintainer of these types and fixed the project location to the maintained one. fixes #26745 https://github.com/xmldom/xmldom --- types/xmldom/index.d.ts | 5 +++-- types/xmldom/tsconfig.json | 3 +-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/types/xmldom/index.d.ts b/types/xmldom/index.d.ts index 8c252389cc..7463cd410a 100644 --- a/types/xmldom/index.d.ts +++ b/types/xmldom/index.d.ts @@ -1,8 +1,9 @@ // Type definitions for xmldom 0.1.22 -// Project: https://github.com/jindw/xmldom.git +// Project: https://github.com/xmldom/xmldom // Definitions by: Qubo +// Karfau // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - +/// declare namespace xmldom { var DOMParser: DOMParserStatic; diff --git a/types/xmldom/tsconfig.json b/types/xmldom/tsconfig.json index f301d6c20f..cbbbfb794c 100644 --- a/types/xmldom/tsconfig.json +++ b/types/xmldom/tsconfig.json @@ -2,8 +2,7 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6", - "dom" + "es6" ], "noImplicitAny": true, "noImplicitThis": true,