From 3561e140bd9ec6c1dfd39d4ba350346044181fd0 Mon Sep 17 00:00:00 2001 From: Jacek Jagiello Date: Tue, 15 Nov 2016 21:56:00 +0100 Subject: [PATCH] Code review fixes --- react-hot-loader/index.d.ts | 23 ++++++++++------------- react-hot-loader/tsconfig.json | 2 +- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/react-hot-loader/index.d.ts b/react-hot-loader/index.d.ts index 202566a5b4..9987a4f28f 100644 --- a/react-hot-loader/index.d.ts +++ b/react-hot-loader/index.d.ts @@ -1,20 +1,17 @@ -// Type definitions for react-hot-loader 3.0.0-beta.6 +// Type definitions for react-hot-loader 3.0 // Project: https://github.com/gaearon/react-hot-loader // Definitions by: Jacek Jagiello // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped import * as React from "react" -declare module "react-hot-loader" { - - interface ErrorReporterProps { - error: any - } - - export interface AppContainerProps { - children?: React.ReactElement, - errorReporter?: React.ComponentClass | React.StatelessComponent - } - - export class AppContainer extends React.Component {} +interface ErrorReporterProps { + error: any } + +export interface AppContainerProps { + children?: React.ReactElement, + errorReporter?: React.ComponentClass | React.StatelessComponent +} + +export class AppContainer extends React.Component {} diff --git a/react-hot-loader/tsconfig.json b/react-hot-loader/tsconfig.json index a25cbaa2ed..f24a0d4bca 100644 --- a/react-hot-loader/tsconfig.json +++ b/react-hot-loader/tsconfig.json @@ -3,7 +3,7 @@ "module": "commonjs", "target": "es6", "noImplicitAny": true, - "strictNullChecks": false, + "strictNullChecks": true, "baseUrl": "../", "jsx": "react", "typeRoots": [