flip/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/FlipsideCrypto/DefinitelyTyped.git synced 2026-02-06 10:56:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[aws-iot-device-sdk] combine multiple signatures (#20229)

Browse Source 
* [aws-iot-device-sdk] combine multiple signatures

In order to use different signatures, I suggest  to combine multiple functions to one, with the different parameter types as a list.

* added a test

Added a test for thingshadow subscribe. The test only covers the error which happened before when using a subscription with a string.
This commit is contained in:
rapmue 2017-10-03 19:28:44 +02:00 committed by Ryan Cavanaugh
parent a380b02379
commit 2ff4dff832
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
types/aws-iot-device-sdk/aws-iot-device-sdk-tests.ts
View File

@ -68,6 +68,8 @@ const thingShadows = new awsIot.thingShadow({
(err: Error, failedTopics: mqtt.Granted[]) => { }
);
thingShadows.subscribe("topic", {}, (error: any, granted: mqtt.Granted) => {});
thingShadows.on("connect", function() {
console.log("connected to AWS IoT");
});

10
types/aws-iot-device-sdk/index.d.ts vendored
View File

@ -333,8 +333,7 @@ export class thingShadow extends NodeJS.EventEmitter {
* @param options
* @param callback
*/
publish(topic: string, message: Buffer, options?: mqtt.ClientPublishOptions, callback?: Function): mqtt.Client;
publish(topic: string, message: string, options?: mqtt.ClientPublishOptions, callback?: Function): mqtt.Client;
publish(topic: string, message: Buffer | string, options?: mqtt.ClientPublishOptions, callback?: Function): mqtt.Client;
/**
* Subscribe to a topic or topics
@ -342,9 +341,7 @@ export class thingShadow extends NodeJS.EventEmitter {
* @param the options to subscribe with
* @param callback fired on suback
*/
subscribe(topic: string, options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
subscribe(topic: string[], options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
subscribe(topic: mqtt.Topic, options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
subscribe(topic: string | string[] | mqtt.Topic, options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
/**
* Unsubscribe from a topic or topics
@ -353,8 +350,7 @@ export class thingShadow extends NodeJS.EventEmitter {
* @param options
* @param callback fired on unsuback
*/
unsubscribe(topic: string, options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
unsubscribe(topic: string[], options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
unsubscribe(topic: string | string[], options?: mqtt.ClientSubscribeOptions, callback?: mqtt.ClientSubscribeCallback): mqtt.Client;
/**
* end - close connection