🤖 Merge PR #46892 [pubnub]: fix pagination types on channel members by @elviswolcott

* add objects listener

* depreciate objects v1 methods

* cleanup callback types

* add type definitions for objects v2

* update deprecation message

* remove todo (I think I got the answer)

* fix lint errors

* update version

* add tests and fix a few things

* fix lint errors

* more specific custom type

* type custom objects

* fix memberships responses

* better types for objects events

* add custom to memberships

* add custom to objects event

* use custom type

* fix merge error

* update test for listener

* fix swapped type parameters

* swap in for mohit

* fix: fix types for pagination
This commit is contained in:
Elvis Wolcott 2020-09-06 18:42:46 -04:00 committed by GitHub
parent 6fe14b2e95
commit 1fb31451d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions

View File

@ -7,7 +7,7 @@
// danduh <https://github.com/danduh>,
// ChristianBoehlke <https://github.com/ChristianBoehlke>,
// divyun <https://github.com/divyun>
// elviswolcot <https://github.com/elviswolcott>
// elviswolcott <https://github.com/elviswolcott>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// @see https://www.pubnub.com/docs/web-javascript/api-reference-configuration
// TypeScript Version: 3.5
@ -1316,7 +1316,7 @@ declare namespace Pubnub {
limit?: number;
page?: {
next?: string;
prev: string;
prev?: string;
};
}
@ -1332,7 +1332,7 @@ declare namespace Pubnub {
limit?: number;
page?: {
next?: string;
prev: string;
prev?: string;
};
}

View File

@ -850,6 +850,10 @@ pubnub.objects.getChannelMembers({
pubnub.objects.setChannelMembers({
channel: 'myChannel',
uuids: ['uuid-1', 'uuid-2'],
page: {
next: "abc",
prev: "def"
}
});
pubnub.objects.removeChannelMembers({