flip/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/FlipsideCrypto/DefinitelyTyped.git synced 2026-02-06 10:56:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(pngjs): update 'this' scope binding in events (#43299)

Browse Source 
- modify core events defintiioin to handle 'this' scope
- test updated for non-arrow syntax usage with events scoped to PNG

https://github.com/lukeapage/pngjs#async-api

Thanks!
This commit is contained in:
Piotr Błażejewicz (Peter Blazejewicz) 2020-03-22 21:47:38 +01:00 committed by GitHub
parent 65988eac2a
commit 0e3a2e2cf8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
types/pngjs/index.d.ts vendored
View File

@ -2,6 +2,7 @@
// Project: https://github.com/lukeapage/pngjs
// Definitions by: Jason Cheatham <https://github.com/jason0x43>
// Florian Keller <https://github.com/ffflorian>
// Piotr Błażejewicz <https://github.com/peterblazejewicz>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
/// <reference types="node" />
@ -47,11 +48,11 @@ export class PNG extends Duplex {
deltaY?: number,
): PNG;
on(event: 'metadata', callback: (metadata: Metadata) => void): this;
on(event: 'parsed', callback: (data: Buffer) => void): this;
on(event: 'error', callback: (error: Error) => void): this;
on(event: 'close', callback: () => void): this;
on(event: string, callback: (...args: any[]) => void): this;
on(event: 'metadata', callback: (this: PNG, metadata: Metadata) => void): this;
on(event: 'parsed', callback: (this: PNG, data: Buffer) => void): this;
on(event: 'error', callback: (this: PNG, error: Error) => void): this;
on(event: 'close', callback: (this: PNG) => void): this;
on(event: string, callback: (this: PNG, ...args: any[]) => void): this;
pack(): PNG;

20
types/pngjs/pngjs-tests.ts
View File

@ -1,5 +1,6 @@
import { PNG } from 'pngjs';
import { createDeflate } from 'zlib';
import fs = require('fs');
const pngs = [
new PNG(),
@ -45,16 +46,35 @@ png.bitblt(pngs[1], 1, 1, 1, 1, 1, 1);
png.on('metadata', metadata => {
metadata.bpp === 1;
});
png.on('metadata', function(metadata) {
this; // $ExpectType PNG
this.width === metadata.width;
this.height === metadata.height;
});
png.on('parsed', data => {
data.byteLength === 1;
});
png.on('parsed', function(data) {
this; // $ExpectType PNG
this.adjustGamma();
this.pack().pipe(fs.createWriteStream('out.png'));
});
png.on('error', error => {
error === new Error('testing');
});
png.on('error', function(error) {
this; // $ExpectType PNG
});
png.on('closed', () => {
// closed
});
png.on('closed', function() {
this; // $ExpectType PNG
});
png.on('foo', () => {});
png.on('foo', function() {
this; // $ExpectType PNG
});
png.pack().adjustGamma();