artin/tauri
1
0
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2026-02-06 13:37:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(bundler/wix): use product name to generate UpgradeCode for MSI (#10967)

Browse Source 
The upgrade code generation was changed due to an accidental regression in #9375. Previously `UpgradeCode` was calculated using the main binary name which was `<product_name>.exe`, but #9375 changed the default main binary name to `<cargo-crate-name>.exe` and thus a different UpgradeCode was generetad.

This PR reverts this change to use product name for `UpgradeCode` generation.
This commit is contained in:
Amr Bashir 2024-09-12 15:22:27 +03:00 committed by GitHub
parent 6566182258
commit 7eb1171e3a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/wix-upgrade-code-regression.md Normal file
View File

@ -0,0 +1,5 @@
---
"tauri-bundler": "patch:bug"
---
Fix generated `UpgradeCode` for MSI not matching MSI installers created with tauri-bundler@v1.

2
crates/tauri-bundler/src/bundle/windows/msi/wix.rs
View File

@ -524,7 +524,7 @@ pub fn build_wix_app_installer(
data.insert("manufacturer", to_json(manufacturer));
let upgrade_code = Uuid::new_v5(
&Uuid::NAMESPACE_DNS,
format!("{}.app.x64", &settings.main_binary_name()).as_bytes(),
format!("{}.exe.app.x64", &settings.product_name()).as_bytes(),
)
.to_string();