mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 18:31:54 +00:00
This PR adds another option to the sensitive metadata allowlist by simplifying the input requirements. to accept `feature` and the allowlisted `privateMetadata` keys for that feature. This change is particularly beneficial when a `feature` has multiple associated `action`(s), and the `privateMetadata` key needs to be allowed for all events related to that feature. Building upon this initial PR: - https://github.com/sourcegraph/sourcegraph/pull/62830/files <!-- 💡 To write a useful PR description, make sure that your description covers: - WHAT this PR is changing: - How was it PREVIOUSLY. - How it will be from NOW on. - WHY this PR is needed. - CONTEXT, i.e. to which initiative, project or RFC it belongs. The structure of the description doesn't matter as much as covering these points, so use your best judgement based on your context. Learn how to write good pull request description: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e?pvs=4 --> ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> CI and unit tests ## Changelog <!-- 1. Ensure your pull request title is formatted as: $type($domain): $what 2. Add bullet list items for each additional detail you want to cover (see example below) 3. You can edit this after the pull request was merged, as long as release shipping it hasn't been promoted to the public. 4. For more information, please see this how-to https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c? Audience: TS/CSE > Customers > Teammates (in that order). Cheat sheet: $type = chore|fix|feat $domain: source|search|ci|release|plg|cody|local|... --> <!-- Example: Title: fix(search): parse quotes with the appropriate context Changelog section: ## Changelog - When a quote is used with regexp pattern type, then ... - Refactored underlying code. --> |
||
|---|---|---|
| .. | ||
| sensitivemetadataallowlist | ||
| telemetryrecorder | ||
| telemetrystore | ||
| telemetrytest | ||
| besteffort.go | ||
| billing_categories.go | ||
| billing_products.go | ||
| BUILD.bazel | ||
| CODENOTIFY | ||
| events.go | ||
| telemetry_test.go | ||
| telemetry.go | ||
| telemetrygateway_test.go | ||
| telemetrygateway.go | ||