mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 19:21:50 +00:00
4a33f98202
Some pretty gnarly code out here, but the gist is to fix some missing user IDs from the V2 telemetry that this massive `GetAndSaveUser` thing reports, caused by a lack of user ID in the context. The core changes are: 1. Parameterize some `GetAndSaveUser` dependencies (logger, telemetry recorder) to make testing easier (improve visibility of logs on failures etc). The change cascades a bit but should be harmless. 2. Generate a `telemetryCtx` with user actor inserted at various point so that telemetry recorder can pick it up. This is a separate context to avoid unexpected auth security problems. 3. Add tests that assert users are (or aren't) included in telemetry events recorded by `GetAndSaveUser` Slack context: https://sourcegraph.slack.com/archives/C01PQEVJ5A9/p1712896597312409?thread_ts=1712874663.564049&cid=C01PQEVJ5A9 ## Test plan New and existing tests pass |
||
|---|---|---|
| .. | ||
| appliance | ||
| batcheshelper | ||
| blobstore | ||
| bundled-executor | ||
| cody-gateway | ||
| embeddings | ||
| executor | ||
| executor-kubernetes | ||
| frontend | ||
| gitserver | ||
| loadtest | ||
| migrator | ||
| msp-example | ||
| pings | ||
| precise-code-intel-worker | ||
| repo-updater | ||
| searcher | ||
| server | ||
| symbols | ||
| syntactic-code-intel-worker | ||
| telemetry-gateway | ||
| worker | ||
| README.md | ||
This directory contains Sourcegraph services and binaries.
When a services is added, removed, or when a service's dependencies change, update our architecture diagram.