mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 17:51:57 +00:00
e93b69bef2
We dived into our go postgres driver and when executing a migration it is executed as a "simple query". Postgres in this case automatically wraps the collection of statements in a transaction, unless it contains transaction statements. So our last attempt at removing the transaction failed. In this attempt we use COMMIT AND CHAIN after each table alter. What this does is commit the current transaction and then starts it up again. From the perspective of the go driver, it is as if there was only one transaction. We then switch the migration to using a transaction to ensure the go drivers clean up the postgres connection in case of failure. IE if a query manually starts a transaction and does not clean up, the connection will be marked as broken for the next person who gets the connection from the pool. By wrapping in go's transaction code the connection will be properly cleaned up. Test Plan: All continuous environments have already succeeded or failed on this migration number. So we will manually run this again against them with the migrator code to ensure the same code paths. If they succeed we will keep code as is, otherwise we will rollback. Additionally we did lots of adhoc testing to understand the characteristics of go and transaction handling. Co-authored-by: Erik Seliger <erikseliger@me.com> |
||
|---|---|---|
| .. | ||
| 1000000027_squashed_migrations_privileged | ||
| 1646761143_squashed_migrations_unprivileged | ||
| 1647894746_dashboard_type | ||
| 1649801281_context_filters | ||
| 1651021000_sort_series | ||
| 1652289966_deprecate-search-stream-generation-method | ||
| 1656517037_group_by | ||
| 1656608833_track_backfill_attempts | ||
| 1659572248_refresh_scoped_insights | ||
| 1663626068_backfill_completed_at | ||
| 1664984848_insights_scheduler_table | ||
| 1665003565_insights_backfill_scheduler_state | ||
| 1665053848_add_insight_series_recording_times | ||
| 1665616961_backfill_table | ||
| 1666632478_add_supports_augmentation_column | ||
| 1666729025_incomplete_points | ||
| 1667309737_backfill_priority_groups | ||
| 1670253074_insight_series_repo_criteria | ||
| 1672740238_add_insights_data_retention_jobs | ||
| 1672917501_add_retention_tables | ||
| 1672921606_data_retention_jobs_series_metadata | ||
| 1674474174_remove_dirty_queries_table | ||
| 1675113463_backfill_repo_query_selector | ||
| 1675347548_add_insight_view_series_num_samples | ||
| 1679051112_remove_commit_index_tables | ||
| 1719914228_insight_series_modify_query | ||
| 1723117231_add_tenants_table | ||
| 1723127349_add_tenant_id_to_most_tables | ||
| BUILD.bazel | ||
| squashed.sql | ||