mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 19:51:50 +00:00
ae338b9797
- Remove support for toggling native tooltips from the browser extension. This let users choose to keep the browser extension installed and partially active on GitHub but not show Sourcegraph's hovers. This functionality is less important now that GitHub's new code nav no longer uses hovers. For old GitHub Enterprise server instances (and GitHub.com users who have not enabled the new code view), users can disable the browser extension if they want to disable Sourcegraph's hover functionality. - Remove hover alerts, which were used to warn users that the results are imprecise. We still show this in a hover badge, which is a much nicer UI for this than a dismissible warning (which felt more "CYA"). - Remove command palette because it was inextricable from notifications and it was only used by the Sourcegraph extension API (which is deprecated and will be removed). - Remove the old notifications UI, which showed notification messages in Sourcegraph and code host UIs. This is no longer necessary with the removal of the command palette, because it is no longer possible to invoke long-running actions whose errors must be shown in a separate, global UI. ## Test plan Existing tests suffice to test the existing code intelligence functionality. This PR just removes functionality. |
||
|---|---|---|
| .. | ||
| aws_codecommit.schema.json | ||
| azuredevops.schema.json | ||
| batch_spec.schema.json | ||
| bitbucket_cloud.schema.json | ||
| bitbucket_server_util.go | ||
| bitbucket_server.schema.json | ||
| bitbucketcloud_util.go | ||
| BUILD.bazel | ||
| changeset_spec.schema.json | ||
| extension_schema.go | ||
| gen.go | ||
| gen.sh | ||
| gerrit.schema.json | ||
| github_util.go | ||
| github.schema.json | ||
| gitlab_util.go | ||
| gitlab.schema.json | ||
| gitolite.schema.json | ||
| go-modules.schema.json | ||
| json-schema-draft-07.schema.json | ||
| jvm-packages.schema.json | ||
| npm-packages.schema.json | ||
| other_external_service.schema.json | ||
| package.json | ||
| pagure.schema.json | ||
| perforce.schema.json | ||
| phabricator.schema.json | ||
| python-packages.schema.json | ||
| README.md | ||
| ruby-packages.schema.json | ||
| rust-packages.schema.json | ||
| schema.go | ||
| settings.schema.json | ||
| site.schema.json | ||
| stringdata.go | ||
| tsconfig.json | ||
Sourcegraph JSON Schemas
JSON Schema is a way to define the structure of a JSON document. It enables typechecking and code intelligence on JSON documents.
Sourcegraph uses the following JSON Schemas:
Modifying a schema
- Edit the
*.schema.jsonfile in this directory. - Run
go generateto update the*_stringdata.jsonfile. - Commit the changes to both files.
- Run
sg startto automatically update TypeScript schema files.
Known issues
- The JSON Schema IDs (URIs) are of the form
https://sourcegraph.com/v1/*.schema.json#, but these are not actually valid URLs. This means you generally need to supply them to JSON Schema validation libraries manually instead of having the validator fetch the schema from the web.