sourcegraph/client
Milan Freml bde3fe9491
[fix] repositories admin page code host filter not adhering to URL query params (#48745)
## Description

1. visit repos page under site admin
1. select code host from code host filter
1. The URL will be updated, copy the URL
1. Visit the URL in a new tab
1. The code host filter won't be pre-populated.

This has now been fixed

fixes #48341
- #48341



## Video

https://www.loom.com/share/3c9749e5fd9c4e38a07e13ad728328c0

## Test plan

Tested locally

## App preview:

- [Web](https://sg-web-milan-fix-repositories-url.onrender.com/search)

Check out the [client app preview
documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews)
to learn more.
2023-03-07 08:48:08 +01:00
..
backstage-backend bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
backstage-frontend bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
branded experimental search input: Hide search type buttons in history mode (#48760) 2023-03-06 19:48:09 +00:00
browser storm: make Apollo Cache persistor use preloaded data (#48706) 2023-03-07 05:00:25 +00:00
build-config build: use JS_BINARY__TARGET instead of BAZEL_BINDIR (#48795) 2023-03-07 06:04:50 +00:00
client-api remove code host native tooltip toggle, hover alerts, command palette, notifs (#48688) 2023-03-06 20:36:18 -08:00
codeintellify bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
common Ship new accessible file and symbol tree (#48610) 2023-03-06 13:34:01 +01:00
eslint-plugin-wildcard bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
extension-api remove code host native tooltip toggle, hover alerts, command palette, notifs (#48688) 2023-03-06 20:36:18 -08:00
extension-api-types remove code host native tooltip toggle, hover alerts, command palette, notifs (#48688) 2023-03-06 20:36:18 -08:00
http-client storm: make Apollo Cache persistor use preloaded data (#48706) 2023-03-07 05:00:25 +00:00
jetbrains bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
observability-client bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
observability-server bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
shared storm: make Apollo Cache persistor use preloaded data (#48706) 2023-03-07 05:00:25 +00:00
storybook bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
template-parser bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
testing bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
vscode remove code host native tooltip toggle, hover alerts, command palette, notifs (#48688) 2023-03-06 20:36:18 -08:00
web [fix] repositories admin page code host filter not adhering to URL query params (#48745) 2023-03-07 08:48:08 +01:00
web-sveltekit sveltekit: React integration (#48269) 2023-02-28 15:49:32 +01:00
wildcard Revert "Setup Wizard: Fix some of paper cuts" (#48781) 2023-03-07 00:37:47 +00:00
BUILD.bazel bazel: add bazel build,tests for client/* (#46193) 2023-02-28 20:46:03 -08:00
README.md [SG-46115] - Merge the search-ui package into the branded package (#46197) 2023-01-11 18:27:19 +01:00

Frontend packages

List

  • web: The web application deployed to http://sourcegraph.com/
  • browser: The Sourcegraph browser extension adds tooltips to code on different code hosts.
  • vscode: The Sourcegraph VS Code extension.
  • extension-api: The Sourcegraph extension API types for the Sourcegraph extensions. Published as sourcegraph.
  • extension-api-types: The Sourcegraph extension API types for client applications that embed Sourcegraph extensions and need to communicate with them. Published as @sourcegraph/extension-api-types.
  • sandboxes: All demos-mvp (minimum viable product) for the Sourcegraph web application.
  • shared: Contains common TypeScript/React/SCSS client code shared between the browser extension and the web app. Everything in this package is code-host agnostic.
  • branded: Contains React components and implements the visual design language we use across our web app and e.g. in the options menu of the browser extension. Over time, components from shared and branded packages should be moved into the wildcard package.
  • wildcard: Package that encapsulates storybook configuration and contains our Wildcard design system components. If we're using a component in two or more different areas (e.g. web-app and browser-extension) then it should live in the wildcard package. Otherwise the components should be better colocated with the code where they're actually used.
  • search: Search-related code that may be shared between all clients, both branded (e.g. web, VS Code extension) and unbranded (e.g. browser extension)
  • storybook: Storybook configuration.

Further migration plan

  1. Fix circular dependency in TS project-references graph wildcard package should not rely on web and probably shared, branded too. Ideally it should be an independent self-contained package.

  2. Decide on package naming and update existing package names. Especially it should be done for a shared package because we have multiple shared folders inside of other packages. It's hard to understand from where dependency is coming from and it's not possible to refactor import paths using find-and-replace.

  3. Investigate if we can painlessly switch to npm workspaces.

  4. Content of packages shared and branded should be moved to wildcard and refactored using the latest FE rules and conventions. Having different packages clearly communicates the migration plan. Developers first should look for components in the wildcard package and then fall-back to legacy packages if wildcard doesn't have the solution to their problem yet.

  5. shared contains utility functions, types, polyfills, etc which is not a part of the Wildcard component library. These modules should be moved into utils package and other new packages: e.g. api for GraphQL client and type generators, etc.

  6. Packages should use package name (e.g. @sourcegraph/wildcard) for imports instead of the relative paths (e.g. ../../../../wildcard/src/components/Markdown) to avoid long relative-paths and make dependency graph between packages clear. (Typescript will warn if packages have circular dependencies). It's easy to refactor such isolated packages, extract functionality into new ones, or even into new repositories.

  7. build or config package should be added later to encapsulate all the configurations reused between packages which will allow removing jest.config, babel.config from the root of the repo.