mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 20:11:54 +00:00
a3ac809415
If the handler function of a periodic goroutine panics, the handler silently dies. I don't see a panic error log, and it is never invoked again. After discussing this on Slack, we concluded that periodic routines are most often part of a background job and that they shouldn't take down entire services when a single component misbehaves. Instead we treat them as an error in that component, which will surface in logs and the background jobs UI. See https://sourcegraph.slack.com/archives/C02UC4WUX1Q/p1696960510011339 for the discussion to go with this behavior. |
||
|---|---|---|
| .. | ||
| recorder | ||
| background_test.go | ||
| background.go | ||
| BUILD.bazel | ||
| CODENOTIFY | ||
| example_test.go | ||
| goroutine_test.go | ||
| goroutine.go | ||
| mocks_test.go | ||
| periodic_test.go | ||
| periodic.go | ||