artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:51:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
de613e92b6
sourcegraph/client/observability-server
History
Quinn Slack de613e92b6
use esbuild for client/web builds (#57365) 
Use [esbuild](https://esbuild.github.io/) instead of Webpack for builds of `client/web`, for faster builds (dev and prod) and greater dev-prod parity. This PR completely removes all use of Webpack in this repository.

`client/web` is the last build target that still uses Webpack; all others have been recently migrated to esbuild. Most devs here have been using esbuild for local dev of `client/web` for the last 6-12 months anyway. The change here is that now our production builds will be built by esbuild.

All sg commands, integration/e2e tests, etc., continue to work as-is. The bundlesize report will take a while to stabilize because the new build products use different filenames.

## Benchmarks

Running `pnpm run generate && time pnpm -C client/web run task:gulp webBuild` and taking the `time` output from the last command:

- Webpack: 62.5s
- esbuild: 6.7s

Note: This understates esbuild's victory for 2 reasons: (1) because esbuild is building both the main and embed entrypoints, whereas Webpack only builds the main entrypoint in this benchmark) and (2) because a lot of it is in the fixed startup time of `gulp`; esbuild incremental rebuilds during local dev only take ~1s.

## Notes

We no longer use Babel to produce web builds (we use esbuild), so we don't need any Babel plugins that optimize the output or improve browser compatibility. Right now, Babel is only used by Jest (for tests) and by Bazel as an intermediate step.
2023-10-23 10:59:06 -07:00
..
src use esbuild for client/web builds (#57365) 2023-10-23 10:59:06 -07:00
.eslintignore web: rename observability package to observability-server (#40397) 2022-08-16 05:15:58 -04:00
.eslintrc.js web: add script for cloning Honeycomb boards (#45402) 2022-12-08 19:24:49 -08:00
BUILD.bazel use esbuild for client/web builds (#57365) 2023-10-23 10:59:06 -07:00
jest.config.js web: rename observability package to observability-server (#40397) 2022-08-16 05:15:58 -04:00
OWNERS Update FPT code owners ping (#44545) 2022-11-17 07:21:49 -05:00
package.json web: migrate from yarn to pnpm (#46143) 2023-01-11 19:50:09 -08:00
README.md web: rename observability package to observability-server (#40397) 2022-08-16 05:15:58 -04:00
tsconfig.json Revert "revert "bazel: improve ESLint rule" (#52853)" (#52878) 2023-06-04 19:06:39 -07:00

README.md

Observability

Shared client infrastructure observability tools.

Vision

  1. Use this package for new scripts related to client infrastructure instrumentation and analysis.
  2. Colocate logic here to benefit from having shared:
    • setup configuration (libhoney.js),
    • observability event schemas,
    • environment variable validators,
    • unit tests.