mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 20:51:43 +00:00
78d95e61d0
This re-opens the reverted #51662. There were three independent issues with the deployed version: 1) There was a stray printf from debugging. It wasn't breaking anything, but it was pretty spammy. 2) I made a change to `httpPost` that made it take an endpoint rather than a repo name, but forgot to update the callsite in `IsContextRequiredForChatQuery`, so it was using an empty string as the URL. This was not caught by tests because the API was not covered by tests before this PR, and I only added tests for the `EmbeddingsSearch` endpoint, not the `IsContextRequiredForChatQuery` endpoint. I've added a new test to this endpoint as part of this un-revert 3) Followup changes in the client to use the new endpoints were using types that did not match the actual response shape from GraphQL and this was causing undefined field accesses. This was not caught by the type system because the problem was at the JSON -> typescript type layer, which is an unchecked type assertion. I squashed the original PR into the first commit, so the second and third commits are the only changes ## Test plan Added a test for `IsContextRequiredForChatQuery` API |
||
|---|---|---|
| .. | ||
| blobstore | ||
| frontend | ||
| github-proxy | ||
| gitserver | ||
| loadtest | ||
| migrator | ||
| repo-updater | ||
| searcher | ||
| server | ||
| sitemap | ||
| sourcegraph-oss | ||
| symbols | ||
| worker | ||
| README.md | ||
This directory contains Sourcegraph services and binaries.
When a services is added, removed, or when a service's dependencies change, update our architecture diagram.