artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:11:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
dc97541a28
sourcegraph/lib/process
History
Robert Lin 78dcd57221
fix/sg: fix mangled log output from sg start and sg run (#63405) 
Right now `sg run` / `sg start` can horribly mangle multi-line output. A
nicely annotated report from @unknwon:


![image](https://github.com/sourcegraph/sourcegraph/assets/23356519/38acbaf9-89dc-4d4b-9fd7-b601f5654240)

Replacing the "buffered process logger" thing with
https://github.com/bobheadxi/streamline which powers `sourcegraph/run`
etc (fairly reliably if I do say so myself) fixes this for a few cases
where I can reliably repro wonky misordered output 😁

## Test plan

`sg start dotcom` with `sg.config.overwrite.yaml`:

```yaml
commands:
  enterprise-portal:
    env:
      SRC_LOG_LEVEL: debug
      PG_QUERY_LOGGING: true
```

Log scope `pgx.devtracer` is consistently formatted ✅ , even with high
volume of logs


![image](https://github.com/sourcegraph/sourcegraph/assets/23356519/5c46f94f-e388-477a-94d3-151d5a3c7468)

Also don't see anything suspicious happening after running for a while
2024-06-20 16:07:27 -07:00
..
BUILD.bazel fix/sg: fix mangled log output from sg start and sg run (#63405) 2024-06-20 16:07:27 -07:00
pipe_test.go lib/process: always pipe _exactly_ what the command outputs (#36574) 2022-06-03 15:13:27 -07:00
pipe.go vcssyncer: Move clone implementation details into syncer (#57688) 2023-10-27 20:55:59 +02:00