sourcegraph/internal/httpcli
Keegan Carruthers-Smith d4e84f0306
httpcli: switch outbound request logger to FIFOList (#46576)
The use of AllKeys had a hidden cost of scanning _every_ key in redis,
not just those associated with outbound requests. So this commit ports
the outbound-requests logger to use a FIFOList, the same datastructure
used by our slow request logger.

This has the additional benefit of reducing our API surface in rcache,
since this was the only user of AllKeys and the Multi* functions.

We could likely do this better since we do things like lookup all logged
requests each time we want to read. But given the value is small (500
items) and it is only done on read (not log time), this seems like a
fine tradeoff versus doing a bigger change.

Test Plan: go test
2023-01-18 10:08:10 +00:00
..
client_test.go linters: re-enable nolintlint and staticcheck SA1019 (#45847) 2022-12-20 14:24:44 +00:00
client.go Revert "Revert "Log external requests (#44286)" (#44890)" aka reapply Log External Requests (#44893) 2022-11-29 14:15:55 +00:00
CODENOTIFY all: remove tsenart from CODENOTIFY (#41035) 2022-08-30 09:35:14 +02:00
doc.go Rename pkg to internal (#5898) 2019-10-07 15:36:41 -07:00
external.go Add redactOutboundRequestHeaders setting (#45156) 2022-12-06 11:54:10 +01:00
redis_logger_middleware_test.go httpcli: switch outbound request logger to FIFOList (#46576) 2023-01-18 10:08:10 +00:00
redis_logger_middleware.go httpcli: switch outbound request logger to FIFOList (#46576) 2023-01-18 10:08:10 +00:00
transport.go httpcli: introduce mutable, wrapped transports (#39775) 2022-08-02 13:12:10 +00:00