sourcegraph/dev/linters/dbconn
Keegan Carruthers-Smith 57a2330d98
searcher: remove unused dependency on dbconn pkg (#61463)
In a recent incident it was bought up that hot fixing searcher had a
risk since it speaks to the DB. I investigated and noticed it doesn't
actually connect, but does have dbconn as an unused transitive dep.

This commit refactors out the bit of logic used by searcher into a pure
package. To do so I did a few renames, but functionally there is no
change in logic other than the searcher binary shedding some heavy
dependencies.

Additionally I updated the go-dbconn-import check to ensure searcher
isn't accidently using the database again.

Test Plan: CI
2024-03-28 17:11:41 +02:00
..
BUILD.bazel bazel: adapt go-dbconn-check.sh lint to nogo (#58971) 2023-12-19 09:56:58 +00:00
dbconn.go searcher: remove unused dependency on dbconn pkg (#61463) 2024-03-28 17:11:41 +02:00