artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:11:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
c712d8d087
sourcegraph/cmd
History
Robert Lin 7d91894a01
chore/otel-collector: upgrade to v0.103.0, remove jaegerexporter (#63171) 
Thread:
https://sourcegraph.slack.com/archives/C1JH2BEHZ/p1717797870638299

One problem caused by this upgrade is that the [deprecated
`jaegerexporter`](https://github.com/open-telemetry/opentelemetry-specification/pull/2858)
no longer builds at all with the last published version, so for the
upgrade to go through it must be removed. I've updated local `sg start`
to work with this change, but some Release team support is needed for
deployment configuration + customer-facing docs changes:
https://sourcegraph.slack.com/archives/C1JH2BEHZ/p1718143249191349?thread_ts=1717797870.638299&cid=C1JH2BEHZ,
since current guidance asks customers to configure `jaegerexporter`.

Part of https://linear.app/sourcegraph/issue/SEC-1680

Closes https://linear.app/sourcegraph/issue/CORE-177

## Test plan

Followed steps shared in
https://sourcegraph.slack.com/archives/C04MYFW01NV/p1718136211292469 to
run locally, since `sg run jaeger otel-collector` alone is insufficient
to get updated images:

```diff
diff --git a/wolfi-images/opentelemetry-collector.yaml b/wolfi-images/opentelemetry-collector.yaml
index b995a3d531b..76de80d4f84 100644
--- a/wolfi-images/opentelemetry-collector.yaml
+++ b/wolfi-images/opentelemetry-collector.yaml
@@ -7,7 +7,11 @@ contents:
     - mailcap
 
     ## opentelemetry-collector packages
-    - opentelemetry-collector@sourcegraph
+    - opentelemetry-collector@branch
+  keyring:
+    - https://packages.sgdev.org/sourcegraph-melange-dev.rsa.pub
+  repositories:
+    - '@branch https://packages.sgdev.org/branches/otel-collector-upgrade'
 
 paths:
   - path: /otel-collector
```

plus `sg wolfi lock opentelemetry-collector` will make `sg run
otel-collector` use the correct image.

**The above diffs SHOULD NOT be committed. The lock should happen
post-merge.**

Spot-checked some traces locally with:

```
sg run jaeger otel-collector
sg start
```


![image](https://github.com/sourcegraph/sourcegraph/assets/23356519/dff88d5a-db9a-4039-b7ba-682e120bdc41)


![image](https://github.com/sourcegraph/sourcegraph/assets/23356519/7e553894-0026-47de-ae38-ba5502b94c63)


## Changelog 

- OpenTelemetry Collector: Upgraded OpenTelemetry Collector to v0.103.0
- OpenTelemetry Collector: The [deprecated `jaegerexporter` has been
removed](https://github.com/open-telemetry/opentelemetry-specification/pull/2858).
Users of `exporter: { jaeger: ... }` in the OpenTelemetry Collector
should use `exporter: { otlp/jaeger: ... }` to send traces directly to
Jaeger via its OTLP receiver.
- Users of the default Jaeger configurations now need to provide
`JAEGER_OTLP_GRPC_PORT` as well as the existing `JAEGER_HOST`
configuration.

---------

Co-authored-by: Anish Lakhwara <anish+github@lakhwara.com>
Co-authored-by: Anish Lakhwara <anish+git@lakhwara.com>
2024-07-10 09:01:41 -07:00
..
appliance feat(appliance): admin password gates most pages (#63523) 2024-07-01 21:56:23 +00:00
batcheshelper
blobstore
bundled-executor
cody-gateway codygateway: Use only one redis pool and make REDIS_ENDPOINT a clear requirement in config (#63625) 2024-07-10 01:54:24 +02:00
cody-gateway-config feature(cody): Data types for encoding LLM Model config via Sourcegraph site config (#63533) 2024-07-01 16:33:43 -07:00
embeddings
enterprise-portal feat/enterpriseportal: database layer for subscriptions upsert (#63703) 2024-07-09 14:35:00 -07:00
executor
executor-kubernetes
frontend chore/otel-collector: upgrade to v0.103.0, remove jaegerexporter (#63171) 2024-07-10 09:01:41 -07:00
gitserver fix(perforce) Fix support for p4breaker workaround scripts (#63611) 2024-07-10 17:39:54 +02:00
loadtest
migrator
msp-example msp/runtime: split contract into JobContract and ServiceContract (#63494) 2024-06-26 19:46:10 +00:00
pings msp/runtime: split contract into JobContract and ServiceContract (#63494) 2024-06-26 19:46:10 +00:00
precise-code-intel-worker
repo-updater scheduler: Simplify query for uncloned repos (#63681) 2024-07-10 02:24:32 +02:00
searcher searcher: Modernize entrypoint and gRPC server (#63700) 2024-07-09 21:10:11 +02:00
server
sourcegraph support fast, simple sg start single-program-experimental-blame-sqs for local dev (#63435) 2024-06-24 21:12:47 +00:00
symbols symbols: Make symbols specific code internal (#63736) 2024-07-10 01:26:22 +02:00
syntactic-code-intel-worker Syntactic indexing produce scip files (#63580) 2024-07-09 13:49:55 +02:00
telemetry-gateway fix/telemetrygateway: reduce context cancellation error reports (#63551) 2024-06-28 12:42:19 -07:00
worker phabricator: Move syncer to worker (#63682) 2024-07-10 02:24:18 +02:00
README.md

README.md

This directory contains Sourcegraph services and binaries.

When a services is added, removed, or when a service's dependencies change, update our architecture diagram.