mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 18:31:54 +00:00
3d36d34b3d
The previous approach to enable race detection was too radical and accidently led to build our binaries with the race flage enabled, which caused issues when building images down the line. This happened because putting a `test --something` in bazelrc also sets it on `build` which is absolutely not what we wanted. Usually folks get this one working by having a `--stamp` config setting that fixes this when releasing binaries, which we don't at this stage, as we're still learning Bazel. Luckily, this was caught swiftly. The current approach insteads takes a more granular approach, which makes the `go_test` rule uses our own variant, which injects the `race = "on"` attribute, but only on `go_test`. ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> CI, being a main-dry-run, this will cover the container building jobs, which were the ones failing. --------- Co-authored-by: Alex Ostrikov <alex.ostrikov@sourcegraph.com> |
||
|---|---|---|
| .. | ||
| command | ||
| definitions | ||
| grafanaclient | ||
| monitoring | ||
| .gitattributes | ||
| BUILD.bazel | ||
| CODENOTIFY | ||
| generate_config_test.sh | ||
| go.mod | ||
| go.sum | ||
| main.go | ||
| README.md | ||
Sourcegraph monitoring generator
This page documents usage (running the generator) and development (of the generator itself). For background and feature documentation, see the generator overview. To learn about how to find, add, and use monitoring, see the Sourcegraph observability developer guide.
Usage
From this directory:
go generate ./...
Logging output supports the Sourcegraph log level flags.
Other configuration options can be customized via flags declared in main.go.
Development
The Sourcegraph monitoring generator consists of three components:
- The main program - this is the primary entrypoint to the generator.
- Definitions, defined in the top-level
monitoring/definitionspackage. This is where the all service monitoring definitions lives. If you are editing monitoring, this is probably where you want to look - see the Sourcegraph observability developer guide. - Generator, defined in the nested
monitoring/monitoringpackage package. This is where the API for service monitoring definitions is defined, as well as the generator code that provides its features.
All features and capabilities for developed for the generator should align with the Sourcegraph monitoring pillars.