mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 19:21:50 +00:00
b2e550c8e5
During an investigation, we saw that Rockskip was not using scip-ctags for symbol parsing when applicable. This means that 1. Rockskip is getting less than optimal symbols for certain languages (like Go) 2. Rockskip is getting no symbols for languages not in universal ctags (Magik) This PR attempts to solve this problem but updating Rockskip to re-use the ctags parser pool logic from symbol service. ### Key Changes - Update parser pool to be re-usable - Push common logic for parser type detection into the parser pool module - Update rockskip service config to take a parser pool - Update and add unit/integration tests ## Questions - What performance impact will using this pooled parser have compared to its previous behavior of spawning a new ctags process each time? ## Test plan - [x] Add unit tests - [x] Update integration tests - [x] Manually test rockskip - [x] Manually test symbolservice (in case of regression) --------- Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com> |
||
|---|---|---|
| .. | ||
| alpine-3.14 | ||
| appliance-frontend | ||
| blobstore | ||
| caddy | ||
| cadvisor | ||
| codeinsights-db | ||
| codeintel-db | ||
| dind | ||
| executor-vm | ||
| grafana | ||
| indexed-searcher | ||
| initcontainer | ||
| jaeger-agent | ||
| jaeger-all-in-one | ||
| node-exporter | ||
| opentelemetry-collector | ||
| postgres_exporter | ||
| postgres-12-alpine | ||
| prometheus | ||
| redis_exporter | ||
| redis-cache | ||
| redis-store | ||
| search-indexer | ||
| sg | ||
| syntax-highlighter | ||
| README.md | ||
Sourcegraph derivative Docker images
This directory contains Sourcegraph docker images which are derivatives of an existing Docker image, but with better defaults for our use cases. For example:
sourcegraph/alpinehandles setting up asourcegraphuser account, installing common packages.sourcegraph/postgres-11.4ispostgres-11.4but with some Sourcegraph defaults.
If you are looking for our non-derivative Docker images, see e.g. /cmd/.../Dockerfile instead.
Building
All images in this directory are built and published automatically on CI:
- See the handbook for more information
- Or see how to build a test image if you need to build a test image without merging your change to
masterfirst.
Adding a new image
- Create a
build.shand add your publishing script to it - the script should end withdocker tag ... "$IMAGE". See the scripts in this directory for examples. - Ensure your new script is executable with
chmod +x build.sh(you can try it via e.g.IMAGE=fake-repo/cadvisor:latest docker-images/$SERVICE/build.sh, or by building a test image) - Add an image to the automated builds pipeline by adding it to
SourcegraphDockerImages.