sourcegraph/dev/linters
Noah S-C 85b09cc66d
bazel: add sgexit lint to nogo (#59092)
Closes https://github.com/sourcegraph/sourcegraph/issues/54847

## Test plan

Sample deliberate error:

```
$ bazel build //dev/sg
INFO: Analyzed target //dev/sg:sg (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: /home/noah/Sourcegraph/sourcegraph/dev/sg/BUILD.bazel:128:10: GoCompilePkg dev/sg/sg.a failed: (Exit 1): builder failed: error executing command (from target //dev/sg:sg) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/go_sdk/builder_reset/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src dev/sg/analytics.go -src dev/sg/checks.go -src ... (remaining 245 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
compilepkg: nogo: errors found by nogo during build-time code analysis:
dev/sg/sg_run.go:28:4: use of `signal.Notify` forbidden because "breaks dev/sg/internal/interrupt" (forbidigo)
Aspect @rules_rust//rust/private:clippy.bzl%rust_clippy_aspect of //dev/sg:sg up-to-date (nothing to build)
INFO: Elapsed time: 52.557s, Critical Path: 26.79s
INFO: 1435 processes: 2 internal, 1433 linux-sandbox.
FAILED: Build did NOT complete successfully
```
2023-12-19 14:46:33 +00:00
..
bodyclose bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
dbconn bazel: adapt go-dbconn-check.sh lint to nogo (#58971) 2023-12-19 09:56:58 +00:00
depguard bazel: fix depgard regexp typo (#58073) 2023-11-02 16:17:21 +02:00
exportloopref bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
forbidigo bazel: add sgexit lint to nogo (#59092) 2023-12-19 14:46:33 +00:00
gocheckcompilerdirectives bzl: port go compiler directives linter from sg lint to nogo (#54485) 2023-06-30 14:31:15 +02:00
gocritic bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
ineffassign bazel: ensure all analyzers respect nolint (#50553) 2023-04-12 13:55:15 +00:00
nolint Linting: make new unused lint respect nolint (#55677) 2023-08-09 17:10:45 +00:00
staticcheck build: add buildifier check to Aspect Workflows (#58566) 2023-11-27 14:58:01 +02:00
tracinglibraries bazel: add tracing libraries lint to nogo (#58929) 2023-12-18 13:50:57 +00:00
unparam bazel: add unparam nogo linter (#50730) 2023-04-18 10:03:35 +00:00
unused Linting: make new unused lint respect nolint (#55677) 2023-08-09 17:10:45 +00:00
go.mod bazel: add sgexit lint to nogo (#59092) 2023-12-19 14:46:33 +00:00
go.sum bazel: adapt go-dbconn-check.sh lint to nogo (#58971) 2023-12-19 09:56:58 +00:00