sourcegraph/client
Quinn Slack 80024726b7
remove extension registry UI and related GraphQL API (#45891)
Removes the extension registry UI and the GraphQL API that is necessary for the registry extension UI.

Any extensions that already exist locally or remotely can still be used with the enableLegacyExtensions site config flag and by enabling the extensions in your user settings.

This change is an intermediate step toward removing the extension registry (except the endpoint that's needed to support pre-4.0 Sourcegraph instances).

I think this PR has a 99% chance of going into the 4.4 release (2023-01-20) and not needing to be reverted. Subsequent PRs that actually make it impossible to use local or custom legacy extensions are still pending customer communication and confirmation. I hope we can merge other future PRs there as well, but there is a greater chance we'd need to revert them before 4.4. By making this PR first, it means less of a revert and more progress regardless of what we learn from customers.
2022-12-22 00:10:56 -08:00
..
branded bazel: ignore files generated into src (#45922) 2022-12-21 20:43:29 -08:00
browser bazel: ignore files generated into src (#45922) 2022-12-21 20:43:29 -08:00
build-config fix: remove circular references in build-config package (#45057) 2022-12-02 12:09:26 +00:00
client-api remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
codeintellify web: upgrade prettier to the latest version to support TS satisfies operator (#45400) 2022-12-08 02:37:23 -08:00
common bazel: move general purpose rules to dev/defs.bzl (#45792) 2022-12-19 10:40:37 +01:00
eslint-plugin-wildcard Update FPT code owners ping (#44545) 2022-11-17 07:21:49 -05:00
extension-api remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
extension-api-types remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
http-client web: upgrade prettier to the latest version to support TS satisfies operator (#45400) 2022-12-08 02:37:23 -08:00
jetbrains bazel: ignore files generated into src (#45922) 2022-12-21 20:43:29 -08:00
observability-client web: upgrade prettier to the latest version to support TS satisfies operator (#45400) 2022-12-08 02:37:23 -08:00
observability-server web: add script for cloning Honeycomb boards (#45402) 2022-12-08 19:24:49 -08:00
search bazel: ignore files generated into src (#45922) 2022-12-21 20:43:29 -08:00
search-ui bazel: ignore files generated into src (#45922) 2022-12-21 20:43:29 -08:00
shared remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
storybook notebooks: remove elm compute component (#45360) 2022-12-07 12:59:05 -08:00
template-parser web: upgrade prettier to the latest version to support TS satisfies operator (#45400) 2022-12-08 02:37:23 -08:00
vscode remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
web remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
wildcard remove extension registry UI and related GraphQL API (#45891) 2022-12-22 00:10:56 -08:00
BUILD.bazel bazel: move general purpose rules to dev/defs.bzl (#45792) 2022-12-19 10:40:37 +01:00
README.md web: remove eslint-plugin-sourcegraph references (#35990) 2022-05-25 04:06:56 +00:00

Frontend packages

List

  • web: The web application deployed to http://sourcegraph.com/
  • browser: The Sourcegraph browser extension adds tooltips to code on different code hosts.
  • vscode: The Sourcegraph VS Code extension.
  • extension-api: The Sourcegraph extension API types for the Sourcegraph extensions. Published as sourcegraph.
  • extension-api-types: The Sourcegraph extension API types for client applications that embed Sourcegraph extensions and need to communicate with them. Published as @sourcegraph/extension-api-types.
  • sandboxes: All demos-mvp (minimum viable product) for the Sourcegraph web application.
  • shared: Contains common TypeScript/React/SCSS client code shared between the browser extension and the web app. Everything in this package is code-host agnostic.
  • branded: Contains React components and implements the visual design language we use across our web app and e.g. in the options menu of the browser extension. Over time, components from shared and branded packages should be moved into the wildcard package.
  • wildcard: Package that encapsulates storybook configuration and contains our Wildcard design system components. If we're using a component in two or more different areas (e.g. web-app and browser-extension) then it should live in the wildcard package. Otherwise the components should be better colocated with the code where they're actually used.
  • search: Search-related code that may be shared between all clients, both branded (e.g. web, VS Code extension) and unbranded (e.g. browser extension)
  • search-ui: Search UI components with branded styling that are shared between clients. For example, the <SearchBox> component that is used in both the web application and VS Code extension.
  • storybook: Storybook configuration.

Further migration plan

  1. Fix circular dependency in TS project-references graph wildcard package should not rely on web and probably shared, branded too. Ideally it should be an independent self-contained package.

  2. Decide on package naming and update existing package names. Especially it should be done for a shared package because we have multiple shared folders inside of other packages. It's hard to understand from where dependency is coming from and it's not possible to refactor import paths using find-and-replace.

  3. Investigate if we can painlessly switch to npm workspaces.

  4. Content of packages shared and branded should be moved to wildcard and refactored using the latest FE rules and conventions. Having different packages clearly communicates the migration plan. Developers first should look for components in the wildcard package and then fall-back to legacy packages if wildcard doesn't have the solution to their problem yet.

  5. shared contains utility functions, types, polyfills, etc which is not a part of the Wildcard component library. These modules should be moved into utils package and other new packages: e.g. api for GraphQL client and type generators, etc.

  6. Packages should use package name (e.g. @sourcegraph/wildcard) for imports instead of the relative paths (e.g. ../../../../wildcard/src/components/Markdown) to avoid long relative-paths and make dependency graph between packages clear. (Typescript will warn if packages have circular dependencies). It's easy to refactor such isolated packages, extract functionality into new ones, or even into new repositories.

  7. build or config package should be added later to encapsulate all the configurations reused between packages which will allow removing jest.config, babel.config from the root of the repo.