sourcegraph/client
Valery Bugakov 7cf15290a2
web: moved Storybook config into a new package (#19569)
* web: moved Storybook config into a new package

* web: added storybook package to client/README

* web: checkin @types/terser-webpack-plugin

* web: yarn deduplicate

* web: prettier

* web: yarn.lock carriage-return

* web: yarn deduplicate

* web: removed redundant eslint command

* web: restored manager-head.html

* web: removed @storybook/core-common dependency for now

* web: moved cover-storybook back to root package.json

* web: updated stories glob

* web: fixed babel-plugin-istanbul cwd

* web: added storybook workspace to exclude list in nyc config

* web: removed redundant change
2021-04-08 17:16:26 +08:00
..
branded web: added theme-redesign toggles to Storybook and web-app (#19684) 2021-04-08 16:25:41 +08:00
browser search contexts: add infinite scrolling to dropdown menu (#19642) 2021-04-06 14:44:25 +02:00
eslint-plugin-sourcegraph web: flatten frontend packages inside of the client folder (#19378) 2021-03-26 15:35:26 +08:00
extension-api web: flatten frontend packages inside of the client folder (#19378) 2021-03-26 15:35:26 +08:00
extension-api-types web: flatten frontend packages inside of the client folder (#19378) 2021-03-26 15:35:26 +08:00
shared search: add count:all (#19756) 2021-04-08 10:44:03 +02:00
storybook web: moved Storybook config into a new package (#19569) 2021-04-08 17:16:26 +08:00
web web: added theme-redesign toggles to Storybook and web-app (#19684) 2021-04-08 16:25:41 +08:00
wildcard Add Wildcard developer documentation (#19523) 2021-03-31 10:30:36 +01:00
README.md web: moved Storybook config into a new package (#19569) 2021-04-08 17:16:26 +08:00

Frontend packages

List

  • web: The web application deployed to http://sourcegraph.com/
  • browser: The Sourcegraph browser extension adds tooltips to code on different code hosts.
  • eslint-plugin-sourcegraph: Not published package with custom ESLint rules for Sourcegraph. Isn't intended for reuse by other repositories in the Sourcegraph org.
  • extension-api: The Sourcegraph extension API types for the Sourcegraph extensions. Published as sourcegraph.
  • extension-api-types: The Sourcegraph extension API types for client applications that embed Sourcegraph extensions and need to communicate with them. Published as @sourcegraph/extension-api-types.
  • shared: Contains common TypeScript/React/SCSS client code shared between the browser extension and the web app. Everything in this package is code-host agnostic.
  • branded: Contains React components and implements the visual design language we use across our web app and e.g. in the options menu of the browser extension. Over time, components from shared and branded packages should be moved into the wildcard package.
  • wildcard: Package that encapsulates storybook configuration and contains our Wildcard design system components. If we're using a component in two or more different areas (e.g. web-app and browser-extension) then it should live in the wildcard package. Otherwise the components should be better colocated with the code where they're actually used.
  • storybook: Storybook configuration.

Further migration plan

  1. Fix circular dependency in TS project-references graph wildcard package should not rely on web and probably shared, branded too. Ideally it should be an independent self-contained package.

  2. Decide on package naming and update existing package names. Especially it should be done for a shared package because we have multiple shared folders inside of other packages. It's hard to understand from where dependency is coming from and it's not possible to refactor import paths using find-and-replace.

  3. Investigate if we can painlessly switch to npm workspaces.

  4. Content of packages shared and branded should be moved to wildcard and refactored using the latest FE rules and conventions. Having different packages clearly communicates the migration plan. Developers first should look for components in the wildcard package and then fall-back to legacy packages if wildcard doesn't have the solution to their problem yet.

  5. shared contains utility functions, types, polyfills, etc which is not a part of the Wildcard component library. These modules should be moved into utils package and other new packages: e.g. api for GraphQL client and type generators, etc.

  6. Packages should use package name (e.g. @sourcegraph/wildcard) for imports instead of the relative paths (e.g. ../../../../wildcard/src/components/Markdown) to avoid long relative-paths and make dependency graph between packages clear. (Typescript will warn if packages have circular dependencies). It's easy to refactor such isolated packages, extract functionality into new ones, or even into new repositories.

  7. build or config package should be added later to encapsulate all the configurations reused between packages which will allow removing jest.config, babel.config from the root of the repo.